fix: avoid duplicate injection alerts for non-vector tools in proxy#327
Merged
andres-linero merged 1 commit intomainfrom Mar 8, 2026
Merged
fix: avoid duplicate injection alerts for non-vector tools in proxy#327andres-linero merged 1 commit intomainfrom
andres-linero merged 1 commit intomainfrom
Conversation
ResponseInspector already checks RESPONSE_INJECTION_PATTERNS for all tools. VectorDBInjectionDetector.check() also always runs injection patterns, so calling both for non-vector tools produced duplicate alerts. Fix: only call vector_detector.check() when is_vector_tool() returns True. Non-vector tools: ResponseInspector covers cloaking + SVG + invisible + injection. Vector tools: ResponseInspector (HIGH) + VectorDBInjectionDetector (CRITICAL, cache_poison_* tagged) — intentional dual signal for elevated risk.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
andres-linero
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #326.
VectorDBInjectionDetector.check()always runsRESPONSE_INJECTION_PATTERNSfor every tool, regardless of whether it's a vector tool. Running bothresponse_inspector.check()andvector_detector.check()for all tools caused duplicate injection alerts for non-vector tools.Fix
Only invoke
vector_detector.check()whenvector_detector.is_vector_tool()returnsTrue.Non-vector tools:
ResponseInspectorhandles cloaking + SVG + invisible chars + base64 + injection — no change.Vector tools (similarity_search, retrieve, rag_query, fetch_context, etc.):
ResponseInspectorfires first (HIGH severity), thenVectorDBInjectionDetectorfires additionally (CRITICAL severity,cache_poison_*tagged). The dual alert is intentional — it gives operators a CRITICAL-severity signal specifically for RAG/vector retrieval paths.Test plan