chore: codebase audit fixes + AUDIT.md#325
Merged
andres-linero merged 1 commit intomainfrom Mar 8, 2026
Merged
Conversation
- scanners/__init__.py: remove duplicate logger (logger/\_logger were same object), move import math to top-level, fix one remaining old logger call - output/__init__.py: Azure + GCP CIS benchmark data was computed but never serialized to JSON output — fixed - mcp_server.py: update cis_benchmark tool description to include Azure, GCP, and Databricks - AUDIT.md: delta-trackable audit document covering scanner architecture, cloud modules, output/API/MCP layer, naming, test gaps, and scanner architecture diagram
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
andres-linero
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Findings from a targeted audit of scanner architecture, cloud modules, and output/MCP layer.
Bugs fixed:
scanners/__init__.py: duplicatelogger/_loggerboth pointing to same object — removedlogger, unified to_loggerscanners/__init__.py:import mathwas declared inside CVSS parsing functions — moved to top-leveloutput/__init__.py: Azure + GCP CIS benchmark results were computed and stored on the report, but never serialized to JSON output — fixedmcp_server.py:cis_benchmarktool description said "AWS or Snowflake only" — updated to include Azure, GCP, DatabricksNew:
AUDIT.md: delta-trackable audit document covering scanner architecture, cloud modules, output/API/MCP layer, naming consistency, test coverage gaps, and a full scanner pipeline diagramTest plan
pytest tests/test_databricks_security.py— 32/32pytest tests/test_core.py— passes (pre-existing version_sync failure is unrelated to this branch)