Migrate ServerInfo to null safety and correct numeric types #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the ServerInfo model and nested classes to be null-safe. Also fixes type mismatches where the API returns floating-point numbers (e.g. reserveBaseXrp) by using double instead of int.
|
@diegolousx I tested my code on Testnet, Mainnet, and Devnet using the XRPL public node endpoints (both HTTP and WSS) and didn’t have any issues fetching the service info. However, your code in this section: gives me a type error: int is not double. Could you please let me know which network and node you are using? Also, apologies for the late response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
• Adds full null safety to the ServerInfo, Info, ValidatedLedger, and related models.
• Updates fields such as reserve_base_xrp, and reserve_inc_xrp from int to double to match actual API response types.
These updates make the code compatible with Dart null safety and prevent runtime type errors.