Fix: bug fixes and optomizations#21
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis pull request refactors aligned memory access and LR/SC reservation tracking across the Execute modules, broadens FENCE decoding, returns ELF entry points for PC initialization, replaces the CLI parser with a stack-safe implementation, and adds tests and changelog/version updates. ChangesCore Execution Engine Alignment and Memory API
ELF Loading, Entry Point, and CLI Optimization
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 1438 1441 +3
Branches 273 280 +7
=========================================
+ Hits 1438 1441 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
ExecuteA64.fs (1)
193-198: 💤 Low valueMinor: same redundant alignment pattern as ExecuteA.fs.
Both the dispatcher and individual
exec*functions applyalignByArchUnsign. Same observation as ExecuteA.fs—idempotent but could be consolidated.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ExecuteA64.fs` around lines 193 - 198, The call to mstate.alignByArchUnsign is being applied twice (once in the dispatcher pattern matching on instr in ExecuteA64.fs and again inside the individual exec* functions), so remove the redundancy by centralizing alignment in one place: either keep mstate.alignByArchUnsign in the dispatcher (the match on instr including LR_D/SC_D/.../InstructionA64.None) and delete the duplicate alignByArchUnsign calls inside the exec* functions, or remove it from the dispatcher and ensure each exec* (e.g. the functions handling LR_D, SC_D, AMO*_D) calls alignByArchUnsign exactly once; update only the code paths that reference mstate.alignByArchUnsign to ensure alignment is applied exactly once and behavior remains unchanged.ExecuteA.fs (1)
192-197: 💤 Low valueMinor: redundant alignment in dispatcher vs individual functions.
The
Executedispatcher appliesalignByArchUnsignto the address (lines 192-197), and eachexec*function also appliesalignByArchUnsignagain. While idempotent and harmless, you could consider removing one site for clarity.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ExecuteA.fs` around lines 192 - 197, The dispatcher currently calls mstate.alignByArchUnsign on addresses before routing to the exec functions, but each exec* function (e.g., execLR_W, execSC_W, execAMOSWAP_W, etc.) also applies alignment, causing redundancy; remove the alignment call from the dispatcher match (the mstate.alignByArchUnsign(...) wrapper) and pass the raw address values (mstate.getRegister i.rs1 or 0L) so individual exec* handlers remain responsible for alignment and no duplicate alignment is performed.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@ExecuteA.fs`:
- Around line 192-197: The dispatcher currently calls mstate.alignByArchUnsign
on addresses before routing to the exec functions, but each exec* function
(e.g., execLR_W, execSC_W, execAMOSWAP_W, etc.) also applies alignment, causing
redundancy; remove the alignment call from the dispatcher match (the
mstate.alignByArchUnsign(...) wrapper) and pass the raw address values
(mstate.getRegister i.rs1 or 0L) so individual exec* handlers remain responsible
for alignment and no duplicate alignment is performed.
In `@ExecuteA64.fs`:
- Around line 193-198: The call to mstate.alignByArchUnsign is being applied
twice (once in the dispatcher pattern matching on instr in ExecuteA64.fs and
again inside the individual exec* functions), so remove the redundancy by
centralizing alignment in one place: either keep mstate.alignByArchUnsign in the
dispatcher (the match on instr including LR_D/SC_D/.../InstructionA64.None) and
delete the duplicate alignByArchUnsign calls inside the exec* functions, or
remove it from the dispatcher and ensure each exec* (e.g. the functions handling
LR_D, SC_D, AMO*_D) calls alignByArchUnsign exactly once; update only the code
paths that reference mstate.alignByArchUnsign to ensure alignment is applied
exactly once and behavior remains unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c1505247-6ef6-44e4-8444-c970e10ab58c
📒 Files selected for processing (15)
CLI.fsDecodeI.fsExecuteA.fsExecuteA64.fsExecuteI.fsExecuteI64.fsMachineState.fsRun.fsTests/run/run.fsTests/rv64a/amoSem.fsTests/unit/app.fsTests/unit/branch.fsTests/unit/cli.fsTests/unit/decode.fsTests/unit/execute.fs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Bug Fixes
Performance
Tests & Docs