You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! Thanks for the PR and sorry for the late reply.
Although your changes were quite small I don't understand them properly, especially the useMemo and yield.
For now I just changed the default IPFS gateway to "https://w3s.link/ipfs/"
i also copied your code quality improvement of adding the tokenIconUri as a useEffect hook
I'll leave this PR open to maybe in the future futher investigate having IPFS fallbacks
Hi! Thanks for the PR and sorry for the late reply.
Sorry also for the late reply
Although your changes were quite small I don't understand them properly, especially the useMemo and yield.
This was a quick fix tried not to change much. I used useMemo because the second useEffect that depends on ipfsGateways causes re-render without it. The getIpfsGateway is just a generator, it just yields the first ipfs gateway url that's tested to be accessible.
For now I just changed the default IPFS gateway to "https://w3s.link/ipfs/" i also copied your code quality improvement of adding the tokenIconUri as a useEffect hook
If it works please do ignore this PR, w3s was reliable on my previous tests even if it was pinned using Pinata, hopefully it stays that way. 😀
I'll leave this PR open to maybe in the future futher investigate having IPFS fallbacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add ipfs gateways