Skip to content

mac/vulkan: set --macos-render-timer to feedback by default #16544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m154k1
Copy link
Contributor

@m154k1 m154k1 commented Jul 14, 2025

This changes frame timing mode to presentation feedback by default on macOS.

From #13825:

in the long run this is supposed to be the default
on my end this works a lot better on higher refresh rate displays (>120hz)

Presentation feedback mode works much better, especially on
higher refresh rate displays.
Copy link

@Akemi
Copy link
Member

Akemi commented Jul 14, 2025

i don't really have a big sample size (besides myself). what are your experience with macos-render-timer=feedback? is it considerable better than the current default or the other modes?

@m154k1
Copy link
Contributor Author

m154k1 commented Jul 14, 2025

what are your experience with macos-render-timer=feedback? is it considerable better than the current default or the other modes?

I've been using it since it was added, and it works perfectly.
The one thing that is definitely noticeable - it has zero vsync jitter with --video-sync=display-* on low refresh rate displays (other modes have ~0.01-0.03 jitter).

--video-sync=display-* still doesn't work on the built-in 120Hz display regardless of the mode, but I don't think it's needed here.

@Akemi
Copy link
Member

Akemi commented Jul 19, 2025

yeah, the vsync jitter is normal, it's supposed to be 'perfectly' timed.

what is the problem with 120hz built-in display? i am not aware of it and it does work on my end. is it worth opening an issue for that?

i am not sure if we should change the default just yet and am still contemplating. need some time to think about it and weigh the pro and cons.

@m154k1
Copy link
Contributor Author

m154k1 commented Jul 19, 2025

what is the problem with 120hz built-in display?

It drops a lot of frames when running with --video-sync=display-*.

is it worth opening an issue for that?

Nah, there's no point in using it on >=120Hz and --video-sync=audio works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants