Skip to content

Conversation

pro100filipp
Copy link

Following discussion in #29 I added some details about movementX/Y support

Copy link
Owner

@mpizenberg mpizenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

I've made small changes suggestions, then it's good to merge.

I'd have committed the changes myself, but the fact your PR comes from your main branch makes it just slighly more annoying because I can't just git checkout your-branch-name and have it auto pull-push from your repo. So I made the suggestions via github interface instead ^^

@pro100filipp
Copy link
Author

I have added all the changes requested 👍

@mpizenberg
Copy link
Owner

Awesome!
I’ll both merge and publish a point release when I have time to do the publication, probably next week. Don’t hesitate to ping me mid-week if I forgot

@tasuki
Copy link

tasuki commented May 11, 2024

Hi, @mpizenberg, it's almost next week 😉

@mpizenberg
Copy link
Owner

mpizenberg commented May 11, 2024 via email

@pro100filipp
Copy link
Author

Hello from the past 😉

@adamdicarlo
Copy link

FWIW, this works on iOS now.

Well, at least on iPhoneOS. I tried it on my iPhone 13 Pro at https://jsgist.org/?src=64c32271a3e7ac51918146b111a2cfd9, which I found via https://bugs.webkit.org/show_bug.cgi?id=255207.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants