fix(model-picker): resolve TimeoutError when selecting current model #241
fix(model-picker): resolve TimeoutError when selecting current model #241cdakotabrown wants to merge 2 commits intompfaffenberger:mainfrom
Conversation
- Convert interactive_model_picker from async to sync using arrow_select() - Remove ThreadPoolExecutor+asyncio.run pattern that caused TimeoutError - Extract build_model_choices() and parse_model_choice() helpers - Move formatting constants to model_picker_constants.py - DRY up update_model_in_input() with _process_model_command() helper - Reduce spinner pause from 300ms to 50ms (matches other menus) - Add 30 unit tests for model picker functions The bug occurred because asyncio.run() in ThreadPoolExecutor created event loop conflicts. The sync arrow_select() works cleanly without these complications.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can customize the tone of the review comments and chat replies.Configure the |
|
Need to test this on my home machine before this is ready for review |
The bug occurred because asyncio.run() in ThreadPoolExecutor created
event loop conflicts. The sync arrow_select() works cleanly without
these complications.