Repository navigation
Peter Melnichenko (luacheck author and maintainer) has passed away; repository migration #198
Description
After seeing all the new issues popping up from unaware people I decided to spread awareness.
Almost a year ago Peter Melnichenko has passed away. I'm going to quote Hisham's open letter to Lua community because I could not phrase it better:
Lua community,
I share with you with great sadness that it has come to my knowledge that Peter Melnichenko has passed away.
Peter was a prolific member of the Lua community, best known as the author of luacheck, the amazing Lua static analyzer, an invaluable tool that I cannot praise enough and has essentially changed the way I write Lua code. What many may not know is that he was also the #2 top committer to the LuaRocks codebase, and had an instrumental role in the maintenance of LuaRocks over the last few years. He was also someone to whom I trusted handing over the LuaCov project. Having worked with him on these projects over the years, I had nothing but good experiences. Peter was not only extremely talented, but also always kind, respectful and friendly.
I had just recently learned how young he was: he had just concluded his bachelor's degree this year, which makes his achievements all the more impressive — I had always somehow assumed he was a seasoned veteran!
FOSS communities bring people together in many different ways. Some of us have the opportunity to meet at events, others interact only online. I've never had the chance to meet Peter in person, but the news of his passing struck me really hard nonetheless. He was a well-liked and respected member of this community, and I'm sure other members of this list would appreciate being informed, hence this message.
The positive impact of his work will remain, and I'm sure we as a community will, in time, carry on his legacy. For now, I would just like to share my grief with you all, and extend my thoughts to his family and friends.
Спасибо, Пётр,
-- Hisham
This repo will no longer be maintained and needs to be forked by someone who's willing to carry on Peter's legacy.
UPD: After a lengthy discussion, the community fork has been finalized at https://github.com/lunarmodules/luacheck
Activity
prepsure commentedon Sep 21, 2019
i just found this tool as part of a vscode extension and that's really sad. i hope someone can continue the project and that everyone who was close to peter is ok.
halx99 commentedon Oct 11, 2019
I'm sorry to hear about that, this is a excellent tool for linting and static analysis of Lua code
kiike commentedon Oct 17, 2019
RIP Peter.
PandaFoss commentedon Oct 24, 2019
Does this repository already have who keeps it alive?
EDIT: I had in mind using this repo to create the Lua version of GoReportCard. What do you think?
treffynnon commentedon Nov 12, 2019
@PandaFoss I don't think that anyone else has commit or admin access to this repo so someone would need to create a fork and maintain that instead as @Azumgi mentioned in the original message:
daurnimator commentedon Nov 12, 2019
FYI, I've taken over ownership of the readthedocs page/org.
To move the repository to a community location, the luarocks organisation would be happy to host it. We have a fork here: https://github.com/luarocks/luacheck
The missing thing right now is someone with the will+expertise+bandwidth to work on luacheck.
[-]Peter Melnichenko (luacheck author and maintainer) has passed away[/-][+]Peter Melnichenko (luacheck author and maintainer) has passed away; repository migration[/+]anonymou3 commentedon Dec 21, 2019
I'm sorry to hear that.
alerque commentedon Jul 29, 2020
I'm sorry to hear about Peter! It's certainly a testament to a well written project that I'm only noticing this since Lua 5.4 things have started cropping up.
I may be willing to pick up maintaining this. I've certainly gotten a lot of mileage out of it. I'll have to give the code a once over and make sure it's in my wheel house.
Also it would be really nice if the official repository could find a home such as the Luarocks org. I know Github has recently started implementing procedures for how to handle repositories when their owners pass away. Now there is a way to designate ahead of time who will be responsible for that, but I know a few cases in the past have been manually re-paranted by Github staff. I wonder if we can contact somebody and ask about this. It seems like if the home was somewhere such as Luarocks and not just some rando they might be willing to executive transfer the repo.
alerque commentedon Jul 29, 2020
There is some hope for this is the deceased user policy, but the voice of an collaborator would hold more weight than mine. Unfortunately I see quite a few contributors but none marked as a collaborator. @daurnimator or @hishamhm have either of you by chance tried contacting Github about this yet?
hishamhm commentedon Jul 29, 2020
@alerque We did, but they request official papers which would be difficult to obtain.
For practical purposes, we can make luarocks.org point to the fork under github.com/luarocks/luacheck and accept PRs there, but there haven't been significant contributions yet to warrant tagging a new release and making the switch (I've done that already for another of Peter's projects, hererocks and managed to get the entry changed in the Python PIP repository).
If the community contributes Lua 5.4 support (or other PRs with fixes, etc.), I'll be happy to push a release. But his projects are still in need of maintainers. I'm short on bandwidth and acting as temporary caretaker of his projects on a best-effort basis (in particular, I'm unfamiliar with the code internals).
alerque commentedon Oct 1, 2020
Now that Lua 5.4 support has been contributed to the fork and a release looks like it is in the works I suggest we go ahead with this and make the fork as official as possible, either there under the luarocks org or under the lunarmodules org.
Either way I'm interested in pitching in especially with issue triage and getting as much stuff from this project ported over (I'll resubmit the PRs and copy over as many issues as seem te be relevant and crosslink the originals so people know where to track them).
alerque commentedon Oct 1, 2020
Although as a last ditch effort to use the deceased user policy to migrate this, is it possible that the necessary docs are something that @notWhaleB (who was a classmate of Peter's) could dig up?
notWhaleB commentedon Oct 1, 2020
Yes, I have a copy of required docs. I will send it to @hishamhm via email.
hishamhm commentedon Oct 13, 2020
Thanks, but if possible, I'd rather not be involved in activating the deceased user policy at this time — I've gone through a lot of this for multiple things related to Peter's passing last year and I'm just not in a mental place to go through it again right now.
@alerque Would you be willing to go through the process? I can move the current fork from luarocks/ to the lunarmodules/ org where you are already added, and with @notWhaleB 's document you should have everything needed.
Thanks for understanding.
alerque commentedon Oct 13, 2020
@hishamhm Yes I'm willing to take care of that end of things. Let's not transfer the the Luarocks fork into Lunarmodules though. I'm not sure how Github handles this kind of migration and if it's different that regular transfers, but if Lunarmodules is the ultimate home we want this under then I think the namespace needs to be clear of forks in order to transfer this repository there. At least stand by until I confirm that. Once this original is transferred I'll help with merging the things that make been done in the fork back into the canonical source repo.
alerque commentedon Oct 13, 2020
@notWhaleB Per the above wish from Hisham can you email me those docs instead? I believe my email address is public on my GitHub profile.
Ruin0x11 commentedon Mar 7, 2021
Is there any progress on this front? I'm wanting to implement a feature to treat warnings as errors and would rather not maintain my own fork. But it doesn't look like much has changed about the repo in the last half year (it's still the top search result for "luacheck").
hishamhm commentedon Mar 7, 2021
alerque commentedon Oct 2, 2021
I did receive the requested documentation and tried several times with GitHub to get ownership transferred to no avail. They want an actual next of kin to handle this, not just a likely programmer community inheritor. In spite of having some cooperation and confirmation from friends they are saying it just isn't enough.
I thing it's probably time we initialize a NON FORK repo on @lunarmodules and work on transferring the community there.
alerque commentedon Oct 2, 2021
I guess the best way to get a non-fork repo going is to migrate the
luarocks/luacheckfork to @lunarmodules and then file a request to disconnect its "fork" status.daurnimator commentedon Oct 4, 2021
Why would we want a non-fork repo? I'm content to remain as a fork in github's metadata.
hishamhm commentedon Oct 4, 2021
Either works as far as I'm concerned — whatever needs the least help from Github support is probably easiest.
@alerque, if you move ahead with the move to @lunarmodules, just let me know when things are set up and I'll transfer the
luacheckfrom theluarocksaccount on luarocks.org to some other account responsible for pushing updated rockspecs (create aluacheckaccount, perhaps? That's the appoarch taken forargparse)alerque commentedon Oct 4, 2021
Fork status has several drawbacks. One is a discoverability penalty. Another is that GitHub doesn't credit people for contributions to forks. That being said that status is something your can change later when/if those and other disadvantages become more apparent.
Given that I was just outvoted on that idea, lets go ahead and transfer
luarocks/luacheckto at least bring those issues/stars/links/watchers/etc. along for the ride. @hishamhm I think you'll have to do that since you're the owner of that repo. Then after it comes in you'll have to do some permission updating.A
luacheckaccount (orlunarmadulesif we want to setup CI based deploys managed by GitHub push access instead of individually, cc @lunarmodules) to handle rockspec pushes is an easy next step after that.hishamhm commentedon Oct 4, 2021
All right! I clicked through the transfer process! Should be happening now
hishamhm commentedon Oct 4, 2021
Transfer is live at https://github.com/lunarmodules/luacheck — I made a quick search-and-replace in the repo to update all URL references.
IIRC Travis CI is currently broken in that repo, and Appveyor might be down as well. It took me some effort to be able to build the binaries for releases locally (this is the adhoc script I've been using locally), and I've never automated the process on Github. Moving the whole thing (CI, builds, releases) to Github Actions is probably the best thing to do, but I haven't looked into that, I have next to no experience with Actions.
alerque commentedon Oct 4, 2021
Fantastic!
I've done some release automation with Actions before, I'll look into it.
Just a heads up I'm a few days away from 6 weeks of almost non-stop travel so at best I'll have a trickle of FOSS contributions for a little while, but I'll be back at it in Dec.
alerque commentedon Oct 4, 2021
I just looked and I have member status on the @lunarmodules org, but that isn't giving me any super powers on the newly migrated repo at all. I suspect the migration kept the original permissions profile instead of inheriting the org defaults. Can you look into giving me access to repo settings so I can work on CI stuff?
hishamhm commentedon Oct 4, 2021
I tweaked the permissions, should be working now!
tst2005 commentedon Dec 10, 2021
Hello everyone who will read this message
I suggest to check if you already
I think that will helps people to find the new lunarmodules repository instead of the legacy one.
Currenty, lunarmodules 101 stars, mpeterv 1522 stars.
Regards,