-
Notifications
You must be signed in to change notification settings - Fork 369
Update dependency react-router-dom to v7 #7683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@beatrice-acasandrei @alexandru-io this is failing on a perf test, can you put this in the perfherder queue to fix the test and upgrade the package? |
031ccbd
to
019d024
Compare
bd1dfe9
to
27f4ee0
Compare
27f4ee0
to
c8f2ee8
Compare
81db26e
to
d99ea73
Compare
d99ea73
to
2d027bd
Compare
2d027bd
to
9579a40
Compare
9579a40
to
674349d
Compare
4580697
to
68c8022
Compare
68c8022
to
a533b36
Compare
a533b36
to
c1cc855
Compare
c1cc855
to
07a2076
Compare
@alexandru-io I asked 6 months ago for this to be looked into as it is blocked on a perfherder test, can we make this a higher priority? |
Sorry @jmaher we'll look into it with higher priority. |
07a2076
to
9e133ce
Compare
Hi @jmaher! We looked into upgrading React Router Dom to V6, but we have some concerns. Because it’s not trivial and it also affects Treeherder, is there maybe someone that can help us with the upgrade? We think this will take some time to accomplish and we’ll need to prioritize our tasks. Please let us know what your thoughts are. Files that need to be updated: Some resources: |
thanks for reaching out, Right now this patch is failing on perfherder tests, so possibly if you could add a fix for the perfherder tests (and code as needed), we could pick up the related work/testing for treeherder proper. |
@jmaher There's no quick fix for this, the tests are not the issue here. The update from V6 affects the routes, without fixing them properly everything is busted. We tried locally to upgrade to v6 and fixing the errors, that's when we realized all of the above. Currently we are looking into a compatibility package that will allow us to migrate incrementally to V6. |
are you saying in order to get the tests working for perfherder you need to fix treeherder routes as well, not just perfherder routes? I would expect some other tests to fail if there were more fixes, but that could be a sign of poor tests |
testing this current PR locally (via |
@jmaher Because |
Yes, that's what I was trying to explain. I'm not sure why the other tests are not failing. |
b7e1593
to
1f71e17
Compare
1f71e17
to
7f5f713
Compare
7f5f713
to
efa58d6
Compare
6dd95eb
to
3b5bba0
Compare
a316560
to
ae40dee
Compare
ae40dee
to
98536fa
Compare
a23d0d7
to
be7ccd6
Compare
f6bc2dd
to
35f158f
Compare
35f158f
to
8cd914a
Compare
8cd914a
to
9ad64ac
Compare
9ad64ac
to
cce5879
Compare
838ff42
to
d7b9106
Compare
2dafc82
to
d0f0aea
Compare
4e740c4
to
f52d7d4
Compare
f52d7d4
to
d849eb3
Compare
d849eb3
to
998bed2
Compare
998bed2
to
3087348
Compare
3087348
to
b657175
Compare
b657175
to
3b10f21
Compare
This PR contains the following updates:
5.1.2
->7.6.3
Release Notes
remix-run/react-router (react-router-dom)
v7.6.3
Compare Source
Patch Changes
[email protected]
v7.6.2
Compare Source
Patch Changes
[email protected]
v7.6.1
Compare Source
Patch Changes
[email protected]
v7.6.0
Compare Source
Patch Changes
[email protected]
v7.5.3
Compare Source
Patch Changes
[email protected]
v7.5.2
Compare Source
Patch Changes
[email protected]
v7.5.1
Compare Source
Patch Changes
[email protected]
v7.5.0
Compare Source
Patch Changes
[email protected]
v7.4.1
Compare Source
Patch Changes
[email protected]
v7.4.0
Compare Source
Patch Changes
[email protected]
v7.3.0
Compare Source
Patch Changes
[email protected]
v7.2.0
Compare Source
Patch Changes
[email protected]
v7.1.5
Compare Source
Patch Changes
[email protected]
v7.1.4
Compare Source
Patch Changes
[email protected]
v7.1.3
Compare Source
Patch Changes
[email protected]
v7.1.2
Compare Source
Patch Changes
[email protected]
v7.1.1
Compare Source
Patch Changes
[email protected]
v7.1.0
Compare Source
Patch Changes
[email protected]
v7.0.2
Compare Source
Patch Changes
[email protected]
v7.0.1
Compare Source
Patch Changes
[email protected]
v7.0.0
Compare Source
Major Changes
Remove the original
defer
implementation in favor of using raw promises via single fetch andturbo-stream
. This removes these exports from React Router: (#11744)defer
AbortedDeferredError
type TypedDeferredData
UNSAFE_DeferredData
UNSAFE_DEFERRED_SYMBOL
,Use
createRemixRouter
/RouterProvider
inentry.client
instead ofRemixBrowser
(#11469)Remove single fetch future flag. (#11522)
Remove
future.v7_startTransition
flag (#11696)Remove
future.v7_normalizeFormMethod
future flag (#11697)Allow returning
undefined
from actions and loaders (#11680)update minimum node version to 18 (#11690)
Remove
future.v7_prependBasename
from the ionternalized@remix-run/router
package (#11726)Remove
future.v7_throwAbortReason
from internalized@remix-run/router
package (#11728)Add
exports
field to all packages (#11675)node package no longer re-exports from react-router (#11702)
updates the minimum React version to 18 (#11689)
future.v7_partialHydration
flag (#11725)<RouterProvider fallbackElement>
propfallbackElement
to ahydrateFallbackElement
/HydrateFallback
on your root routefuture.v7_partialHydration
(when usingfallbackElement
),state.navigation
was populated during the initial loadfuture.v7_partialHydration
,state.navigation
remains in an"idle"
state during the initial loadRemove
future.v7_fetcherPersist
flag (#11731)Minor Changes
Link
/NavLink
when using Remix SSR (#11402)ScrollRestoration
so it can restore properly on an SSR'd document load (#11401)RouterProvider
. When running from a Remix-SSR'd HTML payload with the properwindow
variables (__remixContext
,__remixManifest
,__remixRouteModules
), you don't need to pass arouter
prop andRouterProvider
will create therouter
for you internally. (#11396) (#11400)Patch Changes
RouterProvider
internals to reduce uneccesary re-renders (#11817)[email protected]
v6.30.1
Compare Source
v6.30.0
Compare Source
v6.29.0
Compare Source
v6.28.2
Compare Source
v6.28.1
Compare Source
v6.28.0
Compare Source
v6.27.0
Compare Source
v6.26.2
Compare Source
v6.26.1
Compare Source
v6.26.0
Compare Source
v6.25.1
Compare Source
v6.25.0
Compare Source
v6.24.1
Compare Source
v6.24.0
Compare Source
v6.23.1
Compare Source
v6.23.0
Compare Source
v6.22.3
Compare Source
v6.22.2
Compare Source
v6.22.1
Compare Source
v6.22.0
Compare Source
v6.21.3
Compare Source
v6.21.2
Compare Source
v6.21.1
Compare Source
v6.21.0
Compare Source
v6.20.1
Compare Source
v6.20.0
Compare Source
v6.19.0
Compare Source
v6.18.0
Compare Source
v6.17.0
Compare Source
v6.16.0
Compare Source
v6.15.0
Compare Source
v6.14.2
Compare Source
v6.14.1
Compare Source
v6.14.0
Compare Source
v6.13.0
Compare Source
v6.12.1
Compare Source
v6.12.0
Compare Source
v6.11.2
Compare Source
v6.11.1
Compare Source
v6.11.0
Compare Source
v6.10.0
Compare Source
v6.9.0
Compare Source
v6.8.2
Compare Source
v6.8.1
Compare Source
v6.8.0
Compare Source
v6.7.0
Compare Source
v6.6.2
Compare Source
v6.6.1
Compare Source
v6.6.0
Compare Source
v6.5.0
Compare Source
v6.4.5
Compare Source
v6.4.4
: v6.4.4Compare Source
What's Changed
action
/loader
function returnsundefined
as revalidations need to know whether the loader has previously been executed.undefined
also causes issues during SSR stringification for hydration. You should always ensure yourloader
/action
returns a value, and you may returnnull
if you don't wish to return anything. (#9511)basename
in static data routers (#9591)ErrorResponse
bodies to contain more descriptive text in internal 403/404/405 scenariosNavLink
and descendant<Routes>
(#9589, #9647)ErrorResponse
instances when using built-in hydration (#9593)basename
in static data routers (#9591)@remix-run/[email protected]
[email protected]
Full Changelog: https://github.com/remix-run/react-router/compare/[email protected]@6.4.4
v6.4.3
Compare Source
v6.4.2
Compare Source
v6.4.1
Compare Source
v6.4.0
Compare Source
v6.3.0
: [email protected]Compare Source
What's Changed
New Contributors
Full Changelog: remix-run/react-router@v6.2.2...v6.3.0
v6.2.2
Compare Source
What's Changed
🐛 Bug Fixes
New Contributors
Full Changelog: remix-run/react-router@v6.2.1...v6.2.2
v6.2.1
Compare Source
This release updates the internal
history
dependency to5.2.0
.Full Changelog: remix-run/react-router@v6.2.0...v6.2.1
v6.2.0
Compare Source
🐛 Bug fixes
RouteProps
element
type, which should be aReactNode
(#8473)useOutlet
for top-level routes (#8483)✨ Features
New Contributors
Full Changelog: remix-run/react-router@v6.1.1...v6.2.0
v6.1.1
Compare Source
In v6.1.0 we inadvertently shipped a new, undocumented API that will likely introduce bugs (#7586). We have flagged
HistoryRouter
asunstable_HistoryRouter
, as this API will likely need to change before a new major release.Full Changelog: remix-run/react-router@v6.1.0...v6.1.1
v6.1.0
Compare Source
🐛 Bug fixes
✨ Features
<Outlet>
can now receive acontext
prop. This value is passed to child routes and is accessible via the newuseOutletContext
hook. See the API docs for details. (#8461)<NavLink>
can now receive a child function for access to its props. (#8164)💅 Enhancements
useMatch
andmatchPath
. For example, when you calluseMatch("foo/:bar/:baz")
, the path is parsed and the return type will bePathMatch<"bar" | "baz">
. (#8030)New Contributors
Full Changelog: remix-run/react-router@v6.0.1...v6.1.0
v6.0.2
Compare Source
✨ Features
reloadDocument
prop to<Link>
. This allows<Link>
to function like a normal anchor tag by reloading the document after navigation while maintaining the relativeto
resolution.🗒️ Docs
🤝 New Contributors
Full Changelog
v6.0.1
Compare Source
🐛 Bug Fixes
<StaticRouter location>
value (#8243)<Route>
inside<Routes>
to help people make the change (#8238)v6.0.0
Compare Source
React Router v6 is here!
Please go read our blog post for more information on all the great stuff in v6 including notes about how to upgrade from React Router v5 and Reach Router.
v5.3.4
Compare Source
We removed the
mini-create-react-context
dependency, moving it into an internal module to eliminate peer dependency warnings for users on React 18 (#9382).Full Changelog: remix-run/react-router@v5.3.3...v5.3.4
v5.3.3
Compare Source
This release fixes a bad version selector in react-router-native.
v5.3.2
Compare Source
v5.3.1
Compare Source
This release adds missing
LICENSE
files to the published build.v5.3.0
Compare Source
This release of
react-router-dom
adds support for passing a function to either theclassName
orstyle
props to conditionally apply values based on the link'sactive
state.This provides similar functionality as the existing
activeClassName
andactiveStyle
props, but is a bit more powerful. For example, you can now easily apply styles exclusively to an inactiveNavLink
as well. This offers a nicer experience for folks who use utility class-based CSS tools such as Tailwind.Note that as of
v6.0.0-beta.3
, theactiveClassName
andactiveStyle
props are removed completely. Adding support for functional className and style props to both v5 and v6 will give v5 users an easier upgrade path.Thanks to @tim-phillips for raising the issue that inspired the change! 🥳
v5.2.1
Compare Source
This release fixes a bug with
<Link>
so that, when theto
location is the same as the current, the history state entry is replaced instead of pushed to the stack. See https://github.com/remix-run/react-router/issues/5362 for details. 🥳Thanks to @guidobouman for the PR and for everyone else who weighed in for the fix!
v5.2.0
Compare Source
This release includes a notable performance boost by separating the "Router" context from the "History" context internally. We also allow every element type for
Link
'scomponent
prop and support asensitive
prop on NavLink for control over case sensitive matching.Enjoy!
Changes
sensitive
prop on NavLink (#7251 by @caseywebdev)component
prop type check (#7276 by @ypyakymiv)mini-create-react-context
(#7288 by @patricksmms)history
to its own context (#7103 by @illuminist)Configuration
📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.