Extract abstract frame and interpreted function data ancestors.#2435
Open
aardvark179 wants to merge 3 commits into
Open
Extract abstract frame and interpreted function data ancestors.#2435aardvark179 wants to merge 3 commits into
aardvark179 wants to merge 3 commits into
Conversation
…ata. These abstract classes allow both the original interpreter's CallFrame and the upcoming InterpreterV2's CallFrameV2 to be used interchangeably for stack traces and debugging purposes. Co-authored-by: Duncan MacGregor <duncan.macgregor@servicenow.com> Co-authored-by: Cam Walter <cam.n.walter@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves a bunch of fields and functionality that will be common between the two interpreters to abstract parent classes. These classes are parameterised to ensure the correct relationship between the various elements. This is the next part of #2426.