-
Notifications
You must be signed in to change notification settings - Fork 217
feat(nimbus): Add collaborators management to feature pages #14278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Screen.Recording.2026-01-06.at.9.28.21.AM.mov |
jaredlockhart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay tested locally, works perfectly. Couple thoughts
-
Maybe call it 'Subscribers'? It's not really the same as 'collaborators' on an experiment since you can't actually make changes to it you're just subscribing to the notifications?
-
Having the 'subscribe' button next to the drop down, where your own email appears so you can subscribe yourself either way is a bit redundant/confusing. If we're gonna put the users own email in the drop down and show it in the last then probably take away the subscribe button?
|
Resolved conflicts in forms.py and views.py: - Kept ToggleReviewSlackNotificationsForm and ToggleReviewSlackNotificationsView from main - Excluded FeatureSubscribeForm, FeatureUnsubscribeForm, FeatureSubscribeView, and FeatureUnsubscribeView - Maintained simplified feature subscribers implementation with single dropdown - All feature subscriber management now done through FeatureCollaboratorsUpdateView
jaredlockhart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep looks good works well thnx @yashikakhurana 🙏

Because
This commit
Fixes #14030