Skip to content

Conversation

@yashikakhurana
Copy link
Contributor

Because

  • Users needed a way to add other people as subscribers to feature configurations
  • Previously, users could only subscribe/unsubscribe themselves, and no one could see who else was subscribed to the feature

This commit

  • Adds a collaborators dropdown on the feature page, allowing users to add/remove any user as a subscriber
  • Single card section to subscribe/unsubscribe and add collaborators

Fixes #14030

@yashikakhurana
Copy link
Contributor Author

Screen.Recording.2026-01-06.at.9.28.21.AM.mov

Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay tested locally, works perfectly. Couple thoughts

  1. Maybe call it 'Subscribers'? It's not really the same as 'collaborators' on an experiment since you can't actually make changes to it you're just subscribing to the notifications?

  2. Having the 'subscribe' button next to the drop down, where your own email appears so you can subscribe yourself either way is a bit redundant/confusing. If we're gonna put the users own email in the drop down and show it in the last then probably take away the subscribe button?

@yashikakhurana
Copy link
Contributor Author

Okay tested locally, works perfectly. Couple thoughts

1. Maybe call it 'Subscribers'?  It's not really the same as 'collaborators' on an experiment since you can't actually make changes to it you're just subscribing to the notifications?

2. Having the 'subscribe' button next to the drop down, where your own email appears so you can subscribe yourself either way is a bit redundant/confusing.  If we're gonna put the users own email in the drop down and show it in the last then probably take away the subscribe button?

makes sense, here is the new design
Screenshot 2026-01-07 at 10 28 25 AM

Resolved conflicts in forms.py and views.py:
- Kept ToggleReviewSlackNotificationsForm and ToggleReviewSlackNotificationsView from main
- Excluded FeatureSubscribeForm, FeatureUnsubscribeForm, FeatureSubscribeView, and FeatureUnsubscribeView
- Maintained simplified feature subscribers implementation with single dropdown
- All feature subscriber management now done through FeatureCollaboratorsUpdateView
Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep looks good works well thnx @yashikakhurana 🙏

@yashikakhurana yashikakhurana added this pull request to the merge queue Jan 7, 2026
Merged via the queue into main with commit 038377a Jan 7, 2026
17 checks passed
@yashikakhurana yashikakhurana deleted the 14030 branch January 7, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add collaborators to feature page

3 participants