Skip to content
This repository was archived by the owner on Jan 31, 2018. It is now read-only.

[t3287] Fixed wonkiness on updateEndAfterExpand #1541

Open
k88hudson wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[t3287] Fixed wonkiness on updateEndAfterExpand #1541

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7281ffe
[t3287] Fixed wonkiness on updateEndAfterExpand
Mar 5, 2013
47032e4
removed passing update options
Mar 5, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/editor/sequencer-editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,9 @@ define( [ "util/mediatypes", "editor/editor", "util/time",
track.addTrackEvent( _trackEvent );
_this.updateTrackEventSafe( _trackEvent, updateOptions );
_butter.unlisten( "mediaready", updateEndAfterExpand );
updateOptions = {};
_butter.currentTime = _popcornOptions.start;
updateUI();
Copy link
Contributor

@cadecairos cadecairos Mar 5, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously, update options was reset before updateUI was called, and upateoptions wasn't passed as a param. Is there a reason it's being reset/passed in?

Copy link
Contributor Author

@k88hudson k88hudson Mar 5, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pass in updateOptions so that there will never be a case where the trackEvent hasn't updated yet with updateUI is run

updateOptions = {};
}

function updateTrackEvent( options ) {
Expand Down Expand Up @@ -433,7 +434,6 @@ define( [ "util/mediatypes", "editor/editor", "util/time",
} else {
fallbackContainer.classList.remove( "show" );
}
console.log( _popcornOptions.source[ 0 ] );
el.value = URI.stripUnique( _popcornOptions.source[ 0 ] ).toString();
},
fallbackUpdateUI = function( el ) {
Expand Down