[DISCO-3738] refactor: Update httpx and refactor tests #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncloudioj
commented
Sep 23, 2025
| """Test the curated recommendations endpoint response is as expected.""" | ||
| async with AsyncClient(app=app, base_url="http://test") as ac: |
There was a problem hiding this comment.
This is the main change – no need to create a new async client for every test (also, the app argument is deprecated in httpx), there is already an test client fixture available.
tiftran
reviewed
Sep 23, 2025
Comment on lines
+542
to
+544
| ], | ||
| indent=None, | ||
| separators=(",", ":"), |
There was a problem hiding this comment.
Aren't those already the default for json dumps? Curious why we're setting them explicitly, im sure im missing something 🙂
There was a problem hiding this comment.
The default is (', ', ': ') with trailing space. The newer version of httpx dumps json strings in the compact mode.
tiftran
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
JIRA: DISCO-3738
Description
My apologies for this unexpected large refactor to an integration test! Needed to upgrade
httpxfor a latest feature for proxying, which deprecated some APIs and broke some tests.PR Review Checklist
Put an
xin the boxes that apply[DISCO-####], and has the same title (if applicable)[load test: (abort|skip|warn)]keywords are applied to the last commit message (if applicable)┆Issue is synchronized with this Jira Task