-
Notifications
You must be signed in to change notification settings - Fork 16
HNT-667: takedown reported content #1068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HNT-667: takedown reported content #1068
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think this does what intended. I only have some Python style suggestions.
"threshold": report_ratio_threshold, | ||
"region": region, | ||
}, | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Sending a dedicated Sentry message gives us better context. 👍
References
JIRA: https://mozilla-hub.atlassian.net/browse/HNT-667
Description
Implement auto-takedown of reported content & alert editorial team
Recommendations will not recommend items if report_count / impression_count > threshold, where threshold is a configurable, to-be-determined value.
An error is logged when an item is excluded by breaching the above threshold.
Sentry is configured to send this error to the Slack channel #fx-curation-station that is monitored by our editorial team.
To safe-guard against a group of users maliciously reporting all items, Merino will only allow a certain fraction of all available recommendations to be taken down automatically.
PR Review Checklist
Put an
x
in the boxes that apply[DISCO-####]
, and has the same title (if applicable)[load test: (abort|skip|warn)]
keywords are applied to the last commit message (if applicable)┆Issue is synchronized with this Jira Task