Fix Playwright tests by adding more descriptive alt text to ad images #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justindarc
reviewed
Aug 22, 2025
packages/core/src/constants.ts
Outdated
| @@ -13,7 +13,7 @@ export const IS_PRODUCTION = process.env.NODE_ENV === "production" | |||
|
|
|||
| export const DEFAULT_SERVICE_ENDPOINT: HTTPSURLString = IS_PRODUCTION | |||
| ? "https://ads.mozilla.org/" // production | |||
| : "https://ads.allizom.org/" // staging | |||
| : "https://ads.mozilla.org/" // staging | |||
There was a problem hiding this comment.
ehhh.. can we just update playwright to set NODE_ENV=production instead?
There was a problem hiding this comment.
Yes, apologies for the mess, that would absolutely be the right way to do it, I will make that change. This was just me trying out a quick way to make sure this approach would work
justindarc
reviewed
Aug 22, 2025
packages/core/test/constants.test.ts
Outdated
| @@ -6,7 +6,7 @@ describe("core/constants.ts", () => { | |||
| }) | |||
|
|
|||
| test("Use staging endpoint URLs when not in production", () => { | |||
| expect(DEFAULT_SERVICE_ENDPOINT).toBe("https://ads.allizom.org/") | |||
| expect(DEFAULT_SERVICE_ENDPOINT).toBe("https://ads.mozilla.org/") | |||
There was a problem hiding this comment.
This isn't testing the right thing anymore.
There was a problem hiding this comment.
Good point, thank you so much. Will fix.
mashalifshin
force-pushed
the
fix-playwright-tests
branch
from
d5a80de to
f30911f
Compare
mashalifshin
changed the title
…e from placement name
mashalifshin
force-pushed
the
fix-playwright-tests
branch
from
b213099 to
4933018
Compare
justindarc
reviewed
Aug 27, 2025
| "example:iife": "npm run build && cd examples/iife && npm install && npm run dev", | ||
| "example:react": "npm run build && cd examples/react && npm install && npm run dev", | ||
| "example:iife": "npm run build:production && cd examples/iife && npm install && npm run dev", | ||
| "example:react": "npm run build:production && cd examples/react && npm install && npm run dev", |
There was a problem hiding this comment.
Can we add example:iife:staging and example:react:staging scripts here to be able to also explicitly run the examples against staging (not as the default)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
We need unique alt text on the ad images for our accessible-first Playwright tests to pass in the example apps, as that's the accessible way to select our ad elements.
Proposed Changes
We now construct alt text for the ad images on the client side in order to contextualize what kind of ad it is for users who aren't navigating visually. And we get the unique ids for the Playwright tests exactly as we need them.
Verification Steps
display.test.tsincoreand make sure it's covering all the cases