This repository was archived by the owner on Feb 9, 2024. It is now read-only.
Merged
Conversation
Set a nonce in *Auth returned in func NewURLAuth(...)
nonce is not used in bewits. This reverts commit 17ebb94.
Revert "Set a nonce in *Auth returned in func NewURLAuth(...)" since
remove explicit check of error message value for stale timestamp
g-k
approved these changes
Jan 7, 2021
| if err != nil { | ||
| return 0, AuthFormatError{"tsm", "malformed base64 encoding"} | ||
| } | ||
| case "error": |
There was a problem hiding this comment.
Seems weird to update offsets when the error key is present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains two upstream fixes:
NewURLAuthfunc name in Godoc tent/hawk-go#12 (awaiting review upstream, but clearly valid)Since the original tent repo seems not to be very actively maintained, I also checked through other forks to see if there were any local security fixes that weren't upstreamed, but there didn't seem to be any.
Note, since I merged the upstream changes, this also pulled in tent#9 and tent#10 which adds a bit of noise to the history, but results in no code changes. However, it keeps the repository history aligned with upstream, which should ease future merges, so is probably better than filtering them out.
CC @ajvb @jvehent