Bug 2028704 - [PHAB-BOT] The feed query has a bug where the last feed id is not being updated properly when a single story fails due to database rollback#2580
Open
dklawren wants to merge 2 commits intomozilla-bteam:masterfrom
Conversation
… id is not being updated properly when a single story fails due to database rollback
There was a problem hiding this comment.
Pull request overview
This PR addresses an issue in the PhabBugz feed polling daemon where a database rollback for one failing story could prevent the “last processed feed id” from being persisted correctly, causing reprocessing on subsequent runs.
Changes:
- Removes the single outer writable DB transaction from
run_query, allowing per-query/per-story transaction scoping. - Wraps each individual feed story’s processing in its own
with_writable_databasetransaction so failures roll back only that story. - Wraps
group_query’s Bugzilla DB reads inwith_readonly_databaseand increases verbosity of last-id logging.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR fixes a transaction scoping bug in Feed.pm. Previously, with_writable_database in run_query wrapped the entire query method, meaning a DB rollback triggered by any single story failure would undo all save_last_id() writes for previously-processed stories. The fix moves with_writable_database inside the per-story loop in feed_query, giving each story its own independent transaction.