Skip to content

Use explicit Boost targets in warehouse_ros_sqlite #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhaschke merged 2 commits into from
Jul 20, 2026
Merged

Use explicit Boost targets in warehouse_ros_sqlite #62

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77eca88
Use explicit Boost targets in warehouse_ros_sqlite
Jul 19, 2026
7e8bce6
Apply suggestions from code review
Tobias-Fischer Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ target_include_directories(${PROJECT_NAME} PUBLIC "$<BUILD_INTERFACE:${CMAKE_CUR

set_property(TARGET ${PROJECT_NAME} PROPERTY CXX_STANDARD 14)

target_include_directories(${PROJECT_NAME} SYSTEM PUBLIC ${Boost_INCLUDE_DIRS})
target_link_libraries(${PROJECT_NAME} PUBLIC
Boost::headers
class_loader::class_loader
rclcpp::rclcpp
warehouse_ros::warehouse_ros
Expand Down Expand Up @@ -64,12 +64,10 @@ if(BUILD_TESTING)
target_link_libraries(SchemaVersion ${PROJECT_NAME})

ament_add_gtest(TestLoader test/TestLoader.cpp)
target_link_libraries(TestLoader ${PROJECT_NAME})
target_link_libraries(TestLoader ${Boost_LIBRARIES})
target_link_libraries(TestLoader ${PROJECT_NAME} Boost::filesystem Boost::thread)

ament_add_gtest(BusyHandler test/BusyHandler.cpp)
target_link_libraries(BusyHandler ${PROJECT_NAME})
target_link_libraries(BusyHandler ${Boost_LIBRARIES})
target_link_libraries(BusyHandler ${PROJECT_NAME} Boost::filesystem Boost::thread)

find_package(ament_lint_auto REQUIRED)
list(APPEND AMENT_LINT_AUTO_EXCLUDE
Expand Down
Loading