Repository navigation
Document and restructure setup.py - #1653
Merged
Merged
Conversation
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
shaunagm
approved these changes
Jan 26, 2026
Collaborator
Author
|
@shaunagm can you re-run the failed tests on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setup.py was not documented at all and the package definitions were inside a function which makes it more confusing to edit. It also made it so it will be very hard to test extras when we get to that point.
I moved the core vs extra dependency creation code into functions, and moved the dependency definitions themselves to constants. I also documented it all.
Hopefully this helps as preparatory work for upcoming packaging changes.