chore: remove deprecated validator, add forbid(unsafe_code)#26
Merged
Conversation
- Delete src/validator.rs and tests/validator.rs (legacy validate() replaced by run_pipeline() in 0.2.0) - Remove backward-compat ValidationResult bridge from scan.rs - Make pipeline_result a direct field instead of Option - Simplify main.rs to use the library crate instead of redeclaring all modules (eliminates all dead code warnings) - Add #![forbid(unsafe_code)] to both lib.rs and main.rs - Migrate fixture integration tests to use pipeline API Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validator.rsmodule and its tests —validate()/ValidationResultwere deprecated in 0.2.0, replaced byrun_pipeline()/PipelineResultmain.rsto use the library crate instead of redeclaring all modules (root cause of 22 dead code warnings)#![forbid(unsafe_code)]to bothlib.rsandmain.rsValidationResultbridge from scan module-747 lines, +46 lines. All 284 tests pass.
Test plan
cargo testpasses (284 tests)cargo clippy -- -D warningsclean🤖 Generated with Claude Code