Skip to content

Only use MinimalAggregatorV3Interface#97

Open
Jean-Grimal wants to merge 3 commits intomainfrom
refactor/interfaces
Open

Only use MinimalAggregatorV3Interface#97
Jean-Grimal wants to merge 3 commits intomainfrom
refactor/interfaces

Conversation

@Jean-Grimal
Copy link
Contributor

Fixes #94

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we decided to use 2 folders so that it avoids the risk of modifying the source code when working on a new contract. Here this is making it possible again, because one can be tempted to modify IStEth for a new oracle that needs other data from stEth.

Does it make sense here to share the interfaces ? Not sure what we gain, but at the same time adding function signatures to the interface should not be a problem at all

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

But I remember we decided to use the minimal interface because some functions were useless in the standard interface.

Right now, when integrators fork the repo to build a new oracle they use the standard interface because it's in morpho-chainlink folder and, thus, implement useless functions (eg Angle, fxusd, etc.). I would recommend to at least change the standard interface to the minimal in the folder mentioned earlier.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jean-Grimal can you make the change please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove AggregatorV3Interface and use MinimalAggregatorV3Interface only

5 participants