Skip to content

fix ivfflat probing on query time #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Adityav369 merged 1 commit into from
Jan 27, 2026
Merged

fix ivfflat probing on query time #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/vector_store/chunk_v2_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,8 @@ async def query_similar(
)

async with self.get_session_with_retry() as session:
await session.execute(text("SET LOCAL ivfflat.probes = :probes"), {"probes": self.ivfflat_probes})
# PostgreSQL SET doesn't support parameterized values; safe since ivfflat_probes is a validated int
await session.execute(text(f"SET LOCAL ivfflat.probes = {self.ivfflat_probes}"))
result = await session.execute(query)
rows = result.all()

Expand Down
3 changes: 2 additions & 1 deletion core/vector_store/pgvector_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,8 @@ async def query_similar(
"""
try:
async with self.get_session_with_retry() as session:
await session.execute(text("SET LOCAL ivfflat.probes = :probes"), {"probes": self.ivfflat_probes})
# PostgreSQL SET doesn't support parameterized values; safe since ivfflat_probes is a validated int
await session.execute(text(f"SET LOCAL ivfflat.probes = {self.ivfflat_probes}"))
# Build query with cosine distance calculation, which is normalized to [0, 2].
# A distance of 0 is perfect similarity.
distance = VectorEmbedding.embedding.op("<=>")(query_embedding)
Expand Down
Loading