raiseIntent bug fixes#322
Merged
Roaders merged 3 commits intomorganstanley:mainfrom Apr 29, 2026
Merged
Conversation
Member
Roaders
commented
Apr 29, 2026
- getAppIntent does not return root agent instance
- fixed race condition with raising an intent and handling the result
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
=======================================
Coverage 91.57% 91.58%
=======================================
Files 41 41
Lines 5212 5215 +3
Branches 911 910 -1
=======================================
+ Hits 4773 4776 +3
Misses 425 425
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Davidhanson90
approved these changes
Apr 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes intent resolution edge cases by ensuring the root agent instance is discoverable via directory intent lookups and by preventing a loopback race where an intent listener could miss its first intentEvent.
Changes:
- Populate the root app’s
instanceLookupfromrootAppDirectoryEntry.interop.intents.listensFor(and refactor duplicate lookup-building logic). - Defer firing pending
awaitIntentListenercallbacks to the next macrotask to avoidintentEventdelivery racing ahead of proxy callback registration. - Bump package versions to
0.12.1, update lockfile, and add changelog entry + targeted tests for both fixes.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| projects/ui-provider/package.json | Version/peerDependency bump to 0.12.1. |
| projects/messaging-provider/package.json | Version/peerDependency bump to 0.12.1. |
| projects/fdc3-web/package.json | Version bump to 0.12.1. |
| projects/fdc3-web/src/app-directory/directory.ts | Populate root instance intent lookup; refactor lookup population into helper. |
| projects/fdc3-web/src/app-directory/directory.spec.ts | Adds regression test asserting root instance is returned by getAppIntent. |
| projects/fdc3-web/src/agent/desktop-agent.ts | Defers intent-listener callback notification via setTimeout(..., 0) to avoid loopback race. |
| projects/fdc3-web/src/agent/desktop-agent.spec.ts | Adds regression test covering the macrotask deferral behavior. |
| package-lock.json | Updates workspace package versions and also upgrades several transitive deps. |
| CHANGELOG.md | Adds 0.12.1 release notes describing both fixes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.