Skip to content

raiseIntent bug fixes#322

Merged
Roaders merged 3 commits intomorganstanley:mainfrom
Roaders:main
Apr 29, 2026
Merged

raiseIntent bug fixes#322
Roaders merged 3 commits intomorganstanley:mainfrom
Roaders:main

Conversation

@Roaders
Copy link
Copy Markdown
Member

@Roaders Roaders commented Apr 29, 2026

  • getAppIntent does not return root agent instance
  • fixed race condition with raising an intent and handling the result

@Roaders Roaders requested a review from a team as a code owner April 29, 2026 09:50
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.58%. Comparing base (d6cf845) to head (d8c336e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #322   +/-   ##
=======================================
  Coverage   91.57%   91.58%           
=======================================
  Files          41       41           
  Lines        5212     5215    +3     
  Branches      911      910    -1     
=======================================
+ Hits         4773     4776    +3     
  Misses        425      425           
  Partials       14       14           
Flag Coverage Δ
unittests 91.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
projects/fdc3-web/src/agent/desktop-agent.ts 93.12% <100.00%> (+0.01%) ⬆️
projects/fdc3-web/src/app-directory/directory.ts 91.81% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Davidhanson90 Davidhanson90 requested a review from Copilot April 29, 2026 14:17
@Roaders Roaders merged commit 8f39a2d into morganstanley:main Apr 29, 2026
6 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes intent resolution edge cases by ensuring the root agent instance is discoverable via directory intent lookups and by preventing a loopback race where an intent listener could miss its first intentEvent.

Changes:

  • Populate the root app’s instanceLookup from rootAppDirectoryEntry.interop.intents.listensFor (and refactor duplicate lookup-building logic).
  • Defer firing pending awaitIntentListener callbacks to the next macrotask to avoid intentEvent delivery racing ahead of proxy callback registration.
  • Bump package versions to 0.12.1, update lockfile, and add changelog entry + targeted tests for both fixes.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
projects/ui-provider/package.json Version/peerDependency bump to 0.12.1.
projects/messaging-provider/package.json Version/peerDependency bump to 0.12.1.
projects/fdc3-web/package.json Version bump to 0.12.1.
projects/fdc3-web/src/app-directory/directory.ts Populate root instance intent lookup; refactor lookup population into helper.
projects/fdc3-web/src/app-directory/directory.spec.ts Adds regression test asserting root instance is returned by getAppIntent.
projects/fdc3-web/src/agent/desktop-agent.ts Defers intent-listener callback notification via setTimeout(..., 0) to avoid loopback race.
projects/fdc3-web/src/agent/desktop-agent.spec.ts Adds regression test covering the macrotask deferral behavior.
package-lock.json Updates workspace package versions and also upgrades several transitive deps.
CHANGELOG.md Adds 0.12.1 release notes describing both fixes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants