support root app directory entry#318
Merged
Roaders merged 3 commits intomorganstanley:mainfrom Apr 23, 2026
Merged
Conversation
Roaders
force-pushed
the
root-app-app-directory
branch
from
f7af091 to
6d46055
Compare
Roaders
force-pushed
the
root-app-app-directory
branch
from
6d46055 to
784c5fd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
==========================================
+ Coverage 91.48% 91.57% +0.08%
==========================================
Files 41 41
Lines 5205 5212 +7
Branches 909 911 +2
==========================================
+ Hits 4762 4773 +11
+ Misses 429 425 -4
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ianalderson
approved these changes
Apr 23, 2026
ianalderson
left a comment
ianalderson
left a comment
There was a problem hiding this comment.
This change looks good to me. I did have to check the applications() getter to understand how the applications array was empty when no rootAppDirectoryEntry was provided, but that all looks fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to set the app directory entry for the root app to specify what intents it listens for for example