Skip to content

Fix raiseIntent race condition#316

Merged
Roaders merged 1 commit intomorganstanley:mainfrom
Roaders:race-fix
Apr 22, 2026
Merged

Fix raiseIntent race condition#316
Roaders merged 1 commit intomorganstanley:mainfrom
Roaders:race-fix

Conversation

@Roaders
Copy link
Copy Markdown
Member

@Roaders Roaders commented Apr 22, 2026

No description provided.

@Roaders Roaders requested a review from a team as a code owner April 22, 2026 14:22
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.48%. Comparing base (8ac3718) to head (b4683a4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
+ Coverage   91.46%   91.48%   +0.01%     
==========================================
  Files          41       41              
  Lines        5193     5200       +7     
  Branches      903      903              
==========================================
+ Hits         4750     4757       +7     
  Misses        429      429              
  Partials       14       14              
Flag Coverage Δ
unittests 91.48% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
projects/fdc3-web/src/agent/desktop-agent-proxy.ts 83.19% <100.00%> (+0.34%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

@ianalderson ianalderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unfamiliar with this code but I think I understand the problem and how it is resolved. I believe that the raise intent and raise intent result responses can be received in a different order to what was previously expected and that this is now addressed by using promises that only resolve when the predicate check confirms the received messages matches the expected type.

Based on this understanding I am approving.

@Roaders Roaders merged commit 7397005 into morganstanley:main Apr 22, 2026
5 checks passed
@Roaders Roaders deleted the race-fix branch April 23, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants