introduce utility that settles async functions to multiple #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context
#154 introduced code that converted most of the
actionsin this sdk to not crash when one/more RPC node(s) were down. However the frontend had no way of knowing which network(s), and which actions were failing.solution
This PR introduces a way for an
actiontoemita diagnostic via a diagnosticHook that the clients can define.Since the client defines the diagnosticHook callback function... and since this callback is an optional param... no frontend clients need to be rewritten to prevent breakage. Frontend clients instead can opt-in to define the callback handlers to improve UX progressively as needed.
design decision
I chose to make diagnosticHook defined at the global client level rather than per
actionto reduce code changes and breakage potential. The actions in this sdk can be changed progressively rather than in one giant PR.notes
converted actions in this PR:
Example of what the frontend might look like when using this dianostic emit utility
example code:
Screen.Recording.2025-09-22.at.7.18.15.PM.mov