Prevent incorrect holds #337
Conversation
Just like must-fix and mdlqa issues, security issues are considered related to the release, so they must be moved to the current queue just like before.
Adding conditions for the CLR part (filter=23329) of the A3b script so that mdlqa and must-fixes don't get held, especially during the last week before the release. The conditions are not applied to the ones in IR (filter=14000) because these are already being properly handled in A1 and A2 functions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #337 +/- ##
=======================================
Coverage 31.75% 31.75%
=======================================
Files 71 71
Lines 3222 3228 +6
=======================================
+ Hits 1023 1025 +2
- Misses 2199 2203 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi, nice ping-pong we have here, just for a bit of history, we used to consider security issues as important and move them. But it was decided that we shouldn't because the "important" classification was too much arbitrary, and manual handling was ok (sort of summary of the issue). See https://tracker.moodle.org/browse/MDLSITE-7296 for reference. Then, in 76ac0e7, we detected that some of the automatisms were still needed and we re-introduced them (partially). The security flagged issues was one of the conditions that was left out. Again, the same MDLSITE has it documented. So, now, some is/are being re-introduced. I just would suggest to compare it with how it was working originally (see the commit), mainly to see if there is any other condition to check (we were also checking privacy or testing related issues, for example). Said that, adding back the level condition (aka security), looks ok to me. Ciao :-) |
|
And, about the 2nd part of the issue... unless I'm wrong... A2 happens before any A3, so the conditions shouldn't be needed there is the previous point already has moved the issues. I think that, historically, that's the reason of A3b not having extra conditions, because any move should have happened already (in A2) and all the remaining issues are candidates to be held. Ciao :-) PS: Take this with a pinch of salt, it's just a theory from my memories, please check. |
Adding conditions for the CLR part (filter=23329) of the A3b script so that mdlqa and must-fixes don't get held, especially during the last week before the release. The conditions are not applied to the ones in IR (filter=14000) because these are already being properly handled in A1 and A2 functions.
junpataleta
force-pushed
the
PreventIncorrectHolds
branch
from
0f449a0 to
0fc3deb
Compare
|
Thanks, Eloy. Yeah, however, A2 does not handle issues in CLR already, so A3b will hold the must-fix and mdlqa CLR issues as well. Regarding adding back the additional components (criterion I think we should reconsider adding criterion |
stronk7
left a comment
stronk7
left a comment
There was a problem hiding this comment.
All ok, for me, then. Good job!
|
Awesome. Thanks, Eloy! Self-merging this! |
3 participants
This PR addresses two issues:
mdlqaissues in CLR are being incorrectly held because the query inrun_A3bfor the CLR part (filter=23329) does not exclude must-fix andmdlqaissues from being held for issues in the CLR queue.