Skip to content

Update for Moodle 5.0: Fix deprecated dropdown menu, variable interpolation, and AMOS view styles #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

Update for Moodle 5.0: Fix deprecated dropdown menu, variable interpolation, and AMOS view styles #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions classes/contributor_selector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@ public function find_users($search) {
$countfields = "SELECT COUNT(*)";

$sql = " FROM {user} u
WHERE ${searchsql}";
WHERE $searchsql";

$order = " ORDER BY ${sortsql}";
$order = " ORDER BY $sortsql";

if (!$this->is_validating()) {
$foundcount = $DB->count_records_sql($countfields.$sql, array_merge($searchparams));
Expand Down
4 changes: 2 additions & 2 deletions classes/maintainer_selector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@ public function find_users($search) {
$countfields = "SELECT COUNT(*)";

$sql = " FROM {user} u
WHERE u.id ${permsql} AND ${searchsql}";
WHERE u.id $permsql AND $searchsql";

$order = " ORDER BY ${sortsql}";
$order = " ORDER BY $sortsql";

if (!$this->is_validating()) {
$foundcount = $DB->count_records_sql($countfields.$sql, array_merge($permparams, $searchparams));
Expand Down
8 changes: 4 additions & 4 deletions classes/stats_manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,9 @@ public function write_buffer() {

$sql = "SELECT id, branch, lang, component, numofstrings
FROM {amos_stats}
WHERE branch ${sqlbranches}
AND lang ${sqllangs}
AND component ${sqlcomponents}";
WHERE branch $sqlbranches
AND lang $sqllangs
AND component $sqlcomponents";

$current = [];
$rs = $DB->get_recordset_sql($sql, array_merge($parambranches, $paramlangs, $paramcomponents));
Expand Down Expand Up @@ -324,7 +324,7 @@ public function get_language_pack_ratio_stats(?int $vercode = null): array {

$sql = "SELECT lang, SUM(numofstrings) AS totalnumofstrings
FROM {amos_stats}
WHERE component ${standardsql}
WHERE component $standardsql
AND branch = :vercode
GROUP BY lang
ORDER BY totalnumofstrings DESC, MAX(timemodified), lang";
Expand Down
2 changes: 1 addition & 1 deletion renderer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ protected function collapsible_stage_tool($title, $content, $helpicon = '', $exp
}

$attr['aria-controls'] = html_writer::random_id('collapse_');
$attr['data-toggle'] = 'collapse';
$attr['data-bs-toggle'] = 'collapse';
$attr['data-target'] = '#'.$attr['aria-controls'];

$output = html_writer::start_div('stagetool '.$extraclasses);
Expand Down
Loading
Loading