Check nvmrc node version names #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazyserver
force-pushed
the
node-version-fix
branch
3 times, most recently
from
c567c81 to
d5467d1
Compare
dpalou
suggested changes
Jul 30, 2025
crazyserver
force-pushed
the
node-version-fix
branch
from
d5467d1 to
34203c6
Compare
dpalou
approved these changes
Jul 30, 2025
dpalou
left a comment
dpalou
left a comment
There was a problem hiding this comment.
Thanks Pau, the code looks good to me now.
Member
Author
|
Test failing are unrelated to the issue. |
sarjona
approved these changes
Jul 31, 2025
Member
sarjona
left a comment
sarjona
left a comment
There was a problem hiding this comment.
Hola @crazyserver!
Thanks for working on this. The patch for Gitpod also looks good and works as expected so I'm happy to approve and merge it :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moodle App now uses version name on .nvmrc file to determine the node version to use.
To select the node image the slash (/) should be replaced by a hyphen (-)