Skip to content

Peer review checklist addition. #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Peer review checklist addition. #1461

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df1fc5e
Peer review checklist addition.
timhunt Nov 10, 2025
114369b
Merge branch 'main' into timhunt-prchecklist-perf
timhunt Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions general/development/process/peer-review/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ Clustering is when the same code is run on different computers and an end user c
Ensure that:

- Any filesystem, database or cache accesses are done in the most efficient way.
- If a change is in a performance critical part of the code (for example the database layer, caching system, locks, SQL query changes ...) then we expect to see some attempt to measure the performance impact of the change reported in a comment in the tracker, or even better verified in the testing instructions. (Good examples: [testing instructions of MDL-82754](https://moodle.atlassian.net/browse/MDL-82754), [this comment in MDL-86601](https://moodle.atlassian.net/browse/MDL-86601?focusedCommentId=1019696); bad example MDL-80815.)
- That any code or function that appear expensive are not in critical paths. eg; They don't load on every page.
- The least possible code is running to complete the task, especially looking for hidden loops. They can appear from calling functions.
- Any code that runs is not specific to a single node. (eg opcache_reset()) This ensures clusters will run correctly.
Expand Down