Allow configuration of traffic distribution policy for gateway services #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if es.Spec.ServiceTrafficDistribution != "" { | ||
| trafficDistribution := es.Spec.ServiceTrafficDistribution | ||
| serviceSpec.TrafficDistribution = &trafficDistribution |
There was a problem hiding this comment.
Do you think it would be helpful to add some validation here for when traffic distribution has an unsupported value?
There was a problem hiding this comment.
My worry would be if k8s supports extra values in the future we have to also update it here and the failure mode even if we errored here is the same as the operator failing to sync a service manifest (it won't update the svc and logs errors)
alinbalutoiu
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently allowing setting topology aware routing (an annotation on services) to reduce cross AZ traffic, but this has lots of limitations and only works for deployments with lots of pods.
Instead lets allow the use of traffic distribution so we can configure service traffic to prefer (but fail back to not) traffic to stay with AZs - this means pods routing to the service of gateways will try and keep within AZ boundaries hopefully reducing cross AZ traffic.