-
Notifications
You must be signed in to change notification settings - Fork 14
POC: Configure ipa-validation-ruleset package #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
31f7e19
486c87b
13c28d4
20bdda6
476a6f6
96b19b6
b656e58
2b6cc71
9aa63ff
3a073af
c2bc6db
01c89f5
9060dda
4bb2502
b3f5c12
58c8dd2
1355fca
97d07d3
84ef351
813ba03
a5d66dc
9486687
520614f
211355c
e48a668
9842e37
22a890c
5c8bf28
6843972
158e3cd
a34a9ff
db9bf44
a4c5ecc
0a0a99f
a86a242
46a00c4
c1c119e
409070c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
name: Semantic Commit Check | ||
|
||
on: | ||
pull_request: | ||
types: [opened, synchronize, reopened, edited] | ||
|
||
jobs: | ||
semantic-commit: | ||
runs-on: ubuntu-latest | ||
name: Check Semantic Commits | ||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 | ||
with: | ||
sparse-checkout: | | ||
openapi/ | ||
tools/spectral | ||
Comment on lines
+15
to
+17
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the purpose of this checkout? |
||
- name: Check PR title | ||
uses: amannn/action-semantic-pull-request@v5 | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
with: | ||
types: | | ||
feat | ||
fix | ||
docs | ||
style | ||
refactor | ||
perf | ||
test | ||
build | ||
ci | ||
chore | ||
revert | ||
requireScope: false | ||
subjectPattern: "^[A-Z].+[^.]$" | ||
subjectPatternError: | | ||
The subject "{subject}" found in the pull request title "{title}" | ||
didn't match the configured pattern. Please ensure that the subject | ||
starts with an uppercase letter and doesn't end with a period. | ||
validateSingleCommit: false |
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,41 @@ | ||||||||||||
name: Publish IPA Validation Framework Package | ||||||||||||
|
||||||||||||
on: | ||||||||||||
workflow_dispatch: | ||||||||||||
push: | ||||||||||||
branches: | ||||||||||||
- main | ||||||||||||
- CLOUDP-329998 | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reminder to remove it before merge |
||||||||||||
paths: | ||||||||||||
- 'tools/spectral/ipa/**' | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nit] Do we want to publish on non code changes like Readme.md |
||||||||||||
|
||||||||||||
jobs: | ||||||||||||
generate-changelog: | ||||||||||||
runs-on: ubuntu-latest | ||||||||||||
steps: | ||||||||||||
- uses: actions/checkout@v4 | ||||||||||||
- run: npm install -g conventional-changelog-cli | ||||||||||||
- name: Generate and Commit Changelog | ||||||||||||
run: | | ||||||||||||
npm run gen-ipa-changelog | ||||||||||||
git add tools/spectral/ipa/CHANGELOG.md | ||||||||||||
git commit -m "chore(changelog): Update changelog" | ||||||||||||
- name: Push Changelog | ||||||||||||
uses: ad-m/github-push-action@master | ||||||||||||
with: | ||||||||||||
github_token: ${{ secrets.GITHUB_TOKEN }} | ||||||||||||
branch: main | ||||||||||||
Comment on lines
+26
to
+27
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI: Unsure if that will work (we do have branch protection rules) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I suggest we get changelog generated in separate PR. |
||||||||||||
publish: | ||||||||||||
runs-on: ubuntu-latest | ||||||||||||
steps: | ||||||||||||
- uses: actions/checkout@v4 | ||||||||||||
- uses: actions/setup-node@v4 | ||||||||||||
with: | ||||||||||||
node-version: '20.x' | ||||||||||||
cache: 'npm' | ||||||||||||
- run: npm ci | ||||||||||||
- run: npm test | ||||||||||||
- uses: JS-DevTools/npm-publish@v3 | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Security recommendation. Do not use tag for third party packages that deal with credentials.
Suggested change
|
||||||||||||
with: | ||||||||||||
token: ${{ secrets.IPA_VALIDATION_NPM_TOKEN }} | ||||||||||||
package: "tools/spectral/ipa/package.json" | ||||||||||||
lovisaberggren marked this conversation as resolved.
Show resolved
Hide resolved
|
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[FYI] Checkout of the repository is optional step if your action does not need repository (uses GH API you can skip it)