-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-5454 & PYTHON-5455 Add preliminary python 3.14 support #2451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'll leave this in draft until we can test with mod_wsgi, which is being deployed to the toolchain now. |
tasks = [".test-standard .standalone-noauth-nossl .python-3.9"] | ||
expansions = dict(GREEN_FRAMEWORK=framework, AUTH="auth", SSL="ssl") | ||
tasks = [".test-standard .standalone-noauth-nossl .python-3.9 .sync"] | ||
expansions = dict(GREEN_FRAMEWORK=framework) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a variant to test gevent with auth + ssl?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming tests pass!
Patch build with all 3.14 tests: https://spruce.mongodb.com/version/688bc29c47b6a10007a2558a/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC (Note that this was prior to fixing gevent and mod_wsgi).
I also noticed that our
test-standard
was not comprehensive enough. It didn't give full coverage of python version + topology combinations, so gevent wasn't even tested on Python 3.14 initially.There were 202 specific tasks for Python 3.14. The total before and after with the changes are as follows:
Before: 1069 tasks across 67 build variants
After: 1200 tasks across 70 build variants