[LG-5391] feat(chat-window): add compact variant #2989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8df75b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stephl3
changed the title
|
Size Change: 0 B Total Size: 1.95 MB ℹ️ View Unchanged
|
stephl3
force-pushed
the
steph/chat-compact-message-feed
branch
from
b9c7353 to
9081728
Compare
stephl3
force-pushed
the
steph/chat-compact-chat-window
branch
from
c9ae233 to
30fce2b
Compare
| const { containerWidth, variant } = useLeafyGreenChatContext(); | ||
|
|
||
| const isCompact = variant === Variant.Compact; | ||
| const isMobile = !!containerWidth && containerWidth < breakpoints.Tablet; |
There was a problem hiding this comment.
Should we just return isMobileSize from the context?
(Also nit that got called out in the nav a while back: technically it's isMobileSize not isMobile since we're not checking the UserAgent or input devices)
There was a problem hiding this comment.
That's a good callout, and I wish I made this change with the addition of variant. Adding isMobileSize to the context now will trigger a major change in chat components that rely on it, and I'd like to avoid that for now. I think we can revisit once we determine with design how we want to approach mobile responsiveness in the compact set of components
TheSonOfThomp
approved these changes
Jul 30, 2025
stephl3
force-pushed
the
steph/chat-compact-message-feed
branch
from
9081728 to
c479bda
Compare
stephl3
force-pushed
the
steph/chat-compact-chat-window
branch
from
30fce2b to
8df75b9
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 31, 2025
…sageFeedStyles (#2988) * chore(message-feed): deprecate lgMessageFeedStyles * refactor(message-feed): testutils, styles, and ScrollToLatestButton * chore(message-feed): add react-intersection-observer dep * feat(message-feed): MessageFeed compact variant * docs(message-feed): README * chore(message-feed): changeset * fix: message spacing * [LG-5391] feat(chat-window): add compact variant (#2989) * feat(chat-window): ChatWindow compact variant * docs(chat-window): README * chore(chat-window): changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
ChatWindow🎟 Jira ticket: LG-5391
✅ Checklist
For bug fixes, new features & breaking changes
pnpm changesetand documented my changes🧪 How to test changes