INTPYTHON-658 Add PolymorphicEmbeddedModelArrayField #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
force-pushed
the
polymorphic-array
branch
from
729fd87 to
d348536
Compare
WaVEV
reviewed
Jul 16, 2025
django_mongodb_backend/fields/polymorphic_embedded_model_array.py
Outdated
Show resolved
Hide resolved
WaVEV
reviewed
Jul 16, 2025
timgraham
force-pushed
the
polymorphic-array
branch
from
d348536 to
e9ae1a5
Compare
WaVEV
approved these changes
Jul 16, 2025
Jibola
approved these changes
Jul 23, 2025
Comment on lines
+25
to
+27
| if not cls._meta.abstract: | ||
| # If embedded_models contains any strings, replace them with the actual | ||
| # model classes. |
There was a problem hiding this comment.
How could this class ever come back as an abstract one?
There was a problem hiding this comment.
If the field is declared on an abstract model.
(The condition is copied from django.db.models.fields.related.RelatedField.contribute_to_class().)
| @@ -89,7 +89,7 @@ def convert_value(value, expression, connection): | |||
| def get_db_converters(self, expression): | |||
| converters = super().get_db_converters(expression) | |||
| internal_type = expression.output_field.get_internal_type() | |||
| if internal_type == "ArrayField": | |||
| if internal_type.endswith("ArrayField"): | |||
timgraham
force-pushed
the
polymorphic-array
branch
from
e9ae1a5 to
6d1f396
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.