feat: use placeholder mql types MONGOSH-2333 #2485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Jun 25, 2025
packages/shell-api/src/collection.ts
Outdated
| @@ -560,7 +561,7 @@ export class Collection< | |||
| @returnType('Document') | |||
| @apiVersions([1]) | |||
| async findOne( | |||
| query: Document = {}, | |||
| query: MQLQuery = {}, | |||
| projection?: Document, | |||
| options: FindOptions = {} | |||
| ): Promise<C['schema'] | null> { | |||
There was a problem hiding this comment.
^ should we also do something for the return types?
There was a problem hiding this comment.
oh wow I totally missed that. Yes I think so.
There was a problem hiding this comment.
I think this was actually the only usage of C['schema'] and I changed it to MQLDocument now. But I can't easily think of other places that should change too 🤔
addaleax
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that these would be easy to find/replace in the autocompleter while being semantically better than what we have and not adding any complexity for TypeScript.