test: Re-apply streams e2e test and add retries to commands MONGOSH-2300 #2484
Conversation
…ONGOSH-2127 (mongodb-js#2459)" (mongodb-js#2477) This reverts commit 07bd8c4.
malexandert
force-pushed
the
MONGOSH-2300
branch
from
41d71a4 to
2fe4bed
Compare
| const { | ||
| STREAMS_E2E_SPI_CONNECTION_STRING = '', | ||
| STREAMS_E2E_DB_USER = '', | ||
| STREAMS_E2E_DB_PASSWORD = '', | ||
| STREAMS_E2E_CLUSTER_CONNECTION_STRING = '', | ||
| } = process.env; |
There was a problem hiding this comment.
Something that confuses me is that between the OG commit and the revert, the .evergreen.yml got updated by a bot which removed my env vars from .evergreen.yml, so reapplying the commit didn't put them back. However, the tests still seem to run, even though they should skip and log that if the right variables aren't present. So I guess having the right values in project settings without specifying them in the .evergreen.yml is sufficient?
There was a problem hiding this comment.
You'll need to add them to .evergreen/evergreen.yml.in, which the .evergreen.yml file is generated from
Having them in the project settings may currently work as a way of passing these env vars, but I'd definitely prefer to use an explicit way of passing them if we can
No description provided.