Skip to content

Conversation

@elibroftw
Copy link

@elibroftw elibroftw commented Apr 29, 2023

Replaces #3820
Closes #3819
note that the reviewer should manually test.

@plowsof
Copy link
Contributor

plowsof commented May 2, 2023

warnings/errors shown on first launch:

2023-05-02 01:14:46.292	E failed to parse remoteNodesSerialized Error: Cannot assign [undefined] to int
2023-05-02 01:14:46.292	W qrc:/components/RemoteNodeList.qml:0: ReferenceError: label is not defined
[...]
2023-05-02 01:14:46.293	W qrc:/components/RemoteNodeList.qml:107: ReferenceError: label is not defined
[...]

my remote node list now looks like: (after adding a label they do not show)
Screenshot from 2023-05-02 02-17-59

creating a new wallet i dont see any of my existing nodes in the suggested list:
Screenshot from 2023-05-02 02-21-40

i have not yet tested this PR's functionality todo

i see this is a rebase, thank you

@elibroftw elibroftw force-pushed the patch-126-rebased branch from 355aa01 to bc08952 Compare May 2, 2023 02:32
@elibroftw
Copy link
Author

I think there's 2 bugs and I think I fixed one of them so check again please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Better Remote Node Experience

3 participants