Open
Conversation
enricodias
reviewed
Jun 5, 2019
Contributor
enricodias
left a comment
enricodias
left a comment
There was a problem hiding this comment.
Why change $_COOKIE["payment_id"] to $_COOKIE["payment_id$invoice_id"] ?
Contributor
Author
|
IIRC there was no other way to get the invoice ID which is required so that payments can be applied correctly. |
serhack
reviewed
Apr 16, 2022
| $payment_id = bin2hex(openssl_random_pseudo_bytes(8)); | ||
| setcookie('payment_id', $payment_id, time()+2700); | ||
| // create cookie per invoice_id. | ||
| setcookie("payment_id$invoice_id", $payment_id, time()+2700); |
Member
There was a problem hiding this comment.
I can't understand the purpose of this change. Why should you call a cookie with the invoice id?
serhack
reviewed
Apr 16, 2022
| $payment_id = bin2hex(openssl_random_pseudo_bytes(8)); | ||
| setcookie('payment_id', $payment_id, time()+2700); | ||
| // create cookie per invoice_id. | ||
| setcookie("payment_id$invoice_id", $payment_id, time()+2700); |
Member
There was a problem hiding this comment.
I can't understand the purpose of this change. Why should you call a cookie with the invoice id?
Contributor
There was a problem hiding this comment.
I think the idea is if you pay more than one invoice in a short time it keeps using the first one set. I ran into that once when testing but didn't see it again so didn't try to implement this change yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.