Open
Conversation
added 4 commits
March 8, 2018 12:25
Bonus Credit config option is now available for paying in XMR. Fixed bug when Invoice was only partially paid.
Now each invoice has it's own cookie for the payment_id. Previously client payments would be applied to any invoice the client opened.
serhack
reviewed
Mar 8, 2018
| $payment_id = monero_payment_id(); | ||
| $invoice_id = stripslashes($_POST['invoice_id']); | ||
| $client_id = stripslashes($_POST['client_id']); | ||
| $payment_id = monero_payment_id($invoice_id); |
Member
There was a problem hiding this comment.
Could you please improve the security of monero_payment_id function? You will be able to inject potentential and dangerous scripts.
Contributor
Author
There was a problem hiding this comment.
I don't know how to improve it. :(
Member
|
@Apexio any news? |
…ite existing files, and reviewed for potential issues with PHP version and module usage in WHMCS 8.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed bugs related to underpaying invoices, paying multiple invoices, and invoice statuses not being updated.
Added (optional) config setting to add a bonus credit to clients credit balance on each successful XMR payment.