Replace legacy modules with Odoo 18 compatible payment_monero_rpc#19
Conversation
niyid
force-pushed
the
feature/payment_monero_rpc
branch
3 times, most recently
from
cd0b3f9 to
b390376
Compare
niyid
force-pushed
the
feature/payment_monero_rpc
branch
from
191ca9e to
a853df3
Compare
TODO - payment_form_monero.js upgrade to OWL 3 Updated README Updated README and sample data Set required confirmations to 2 Handling logo display for payment provider and payment method Added preconfigured support for more popular currencies on payment provider and payment method Minimum confirmations should be 2 and updated config settings. Use 'noupdate' for data Improved on Unit Tests Compacting consolidation of 5 commits; make it easier for testing
niyid
force-pushed
the
feature/payment_monero_rpc
branch
from
e6a938d to
945a3bf
Compare
|
Thank you for the prompt response and providing this repository. |
|
@serhack I may have prematurely merged this in without a full review. We will revert if need be. I do not have time to dedicate to this project. |
|
Thanks for taking the action you took. I volunteer to continue managing the
repository if necessary and promise to manage it to the best of my ability.
…On Thu, 19 Jun 2025, 14:31 t-900-a, ***@***.***> wrote:
*t-900-a* left a comment (monero-integrations/moneroodoo#19)
<#19 (comment)>
@serhack <https://github.com/serhack> I may have prematurely merged this
in without a full review. We will revert if need be. I do not have time to
dedicate to this project.
—
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE2MWRY7MYIMSGZOV3NBZOT3EK3TLAVCNFSM6AAAAAB4YVSKHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSOBYGEYTEMZUGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
The README.md file needs to be updated. Should the old template still be
used and simply update the version number to '18.0.0.0.1'? If there are any
additions, please let me know.
…On Thu, Jun 19, 2025 at 2:35 PM Oyeniyi Dada ***@***.***> wrote:
Thanks for taking the action you took. I volunteer to continue managing
the repository if necessary and promise to manage it to the best of my
ability.
On Thu, 19 Jun 2025, 14:31 t-900-a, ***@***.***> wrote:
> *t-900-a* left a comment (monero-integrations/moneroodoo#19)
> <#19 (comment)>
>
> @serhack <https://github.com/serhack> I may have prematurely merged this
> in without a full review. We will revert if need be. I do not have time to
> dedicate to this project.
>
> —
> Reply to this email directly, view it on GitHub
> <#19 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AE2MWRY7MYIMSGZOV3NBZOT3EK3TLAVCNFSM6AAAAAB4YVSKHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSOBYGEYTEMZUGA>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
|
I have done the first design of the Monero-Odoo Integration logo. I will
try more and share so the best can be chosen.
…On Fri, Jun 20, 2025 at 9:14 AM Oyeniyi Dada ***@***.***> wrote:
The README.md file needs to be updated. Should the old template still be
used and simply update the version number to '18.0.0.0.1'? If there are any
additions, please let me know.
On Thu, Jun 19, 2025 at 2:35 PM Oyeniyi Dada ***@***.***> wrote:
> Thanks for taking the action you took. I volunteer to continue managing
> the repository if necessary and promise to manage it to the best of my
> ability.
>
> On Thu, 19 Jun 2025, 14:31 t-900-a, ***@***.***> wrote:
>
>> *t-900-a* left a comment (monero-integrations/moneroodoo#19)
>> <#19 (comment)>
>>
>> @serhack <https://github.com/serhack> I may have prematurely merged
>> this in without a full review. We will revert if need be. I do not have
>> time to dedicate to this project.
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#19 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/AE2MWRY7MYIMSGZOV3NBZOT3EK3TLAVCNFSM6AAAAAB4YVSKHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSOBYGEYTEMZUGA>
>> .
>> You are receiving this because you authored the thread.Message ID:
>> ***@***.***>
>>
>
|
|
|
|
|
I agree, We have merged this one way too quickly. Hi @niyid Thank you for your significant effort and contribution to this project. It's great to see this level of engagement, and we appreciate you taking the time to put this pull request together. The PR was merged prematurely before a full review could be completed, and I've identified several key architectural and functional issues that need to be addressed. We can work through these together, and we will revert the merge if necessary while we sort them out. I've broken the feedback down into several point
Action Required: Please retarget this work to the 18.0 branch. The master branch is not used for version-specific development.
This creates two problems: Maintainability: A single "do-it-all" module is difficult to maintain and extend. Unwanted Dependencies: It forces users to install unrelated packages. For example, a B2B service company should not be required to install Point of Sale to use our Monero integration. Action Required: The functionality needs to be refactored into separate, modular packages as originally designed. For example, the POS-related payment logic should be in its own module that depends on a base "Monero payments" module. If you have any feedback on the architecture please discuss it in issue #6 Functional ScopeMonero as a Compliant Currency The current implementation appears to have moved away from this by not including the XMR currency setup & base Cryptocurrency modules. This functionality is critical and needs to be a central part of the base module. Functional testAfter above findings after my quick code scan, I tried to perform a functional test of this code. Thank you again for your contribution. I look forward to collaborating with you to get the monero integration into a stable and production ready state. "I do tend to have a different approach, e.g. working on the 14 branch to complete the features and then migrate it to the newer version. Added benefit it will provide an upgrade path for current users" (Although no one is (or should) run the current code in production.) |
|
Thank you @bosd. This is a detailed architectural critique of the integration module. I do agree that trade-offs are to be carefully considered for instance with regards to modularity for singular packaging rather than the former 2 modules. I have seen that the collection of dependency modules that installing POS separately would not be so disparate, as POS functionality is expectedly related to Online Market functionality and for most use-cases go hand in hand. So the trade off here is the simplicity in the installation - making things less complicated for the user and admin. I will take a further look at the architectural section; I do agree that the structure of the repository should correspond with the Odoo version considering how rapidly the versions 14 through 18 are so fragmental and different (example is the changes from OWL-1, OWL-2 and then OWL-3). But one thing in particular you missed is the EOL for each version. Currently Odoo 14, and 15 have reached EOL. Odoo 16 reaches EOL in October (4 months). Odoo 14, 15 and 16 are no longer worth supporting. Even Odoo 17 is borderline as it reaches EOL in October 2026 (just next year). The XMR currency setup is automated in the data setup and uses the currency to automatically create Monero payment provider and payment method. With regards to the functional test, please provide the logs so I can be able to suggest solutions. Once again thank you and welcome back. |
|
|
|
@bosd can you create the 18.0 branch? Not possible to retarget to a branch that doesn't yet exist ;) Whether you revert the merge or not, is up to you |
|
@bosd are you aware of #20 , (PR'd to branch 15 and has "fixes for "versions 16, 17 and 18, in their respective branches in [his] repository."
@xineohp2021 has interpreted this comment as "more of a protest which against having to merge so fast after @serhack had done the review and given him the go ahead to merge" so would be nice for this to be clarified. @t-900-a has merged 1 of 2 PR's that claim to do the same thing so i'd like to see the reasoning behind this as there is an open bounty for this currently at over 10 XMR https://bounties.monero.social/posts/24/10-233m-upgrade-monero-integration-to-support-odoo-15 |
|
@plowsof, at the time of the merge, I was unaware of the ongoing work due to a bounty. I am unable to locate the specific comment you mentioned and find it somewhat unclear: "more of a protest which against having to merge so fast after serhack had done the review and given him the go ahead to merge." @plowsof, the current situation is confusing. I have reached out to you via Matrix and require additional details to stay involved. I am reluctant to engage in public disputes that resemble petty arguments over trivial matters. |
|
i forgot to be more specific: the comment "more of a protest.." occurred in the bounties room on matrix. That is niyid telling us why you merged this PR. If this interpretation is wildly inaccurate or close to the truth then that'd be good to know. i'm sure this will be cleared up eventually 🙏 |
|
"wildly inaccurate" |
I need to clarify here - what I said was t-900-a appeared to have protested against merging because he had been instructed to, and which could only have come about because a code review was done (I assume that code reviews come before merging of code).
I need to also point out once again that Odoo 14, 15 and marginally 16 really should not be supported because of the EOL as shown in the link - https://www.odoo.com/documentation/18.0/administration/supported_versions.html
They are not even supported any longer on popular hosting websites. Here you suggest that @serhack worked with them which appears not to be so.
Lastly, there is no contention here.
I understand that the bounty goes back to 2021 when Odoo 15 was just being released, but within a space of 4 years it had become totally outdated and reached EOL with 3 releases since then. We just have to move with the times. It is just really surprising that there was no interest within those 4 years, until I took it up. |
Bumping ^
|
|
Dear All, Odoo 19 was released last weekend and that effectively means Odoo 16 has reached EOL. I plan to upgrade #22 to Odoo 19 and in fact I started working on it and with a few changes should be done. But work cannot continue until I have received an ACK for the current pending PR. I look forward to your cooperation. Regards. |
6 participants
Monero RPC Payment Module for Odoo 18
Overview
This module provides Monero cryptocurrency payment integration for Odoo 18 using direct RPC calls to the Monero daemon and wallet. The module has been completely refactored from previous versions to ensure compatibility with Odoo 18's architecture while maintaining the core functionality of processing Monero payments.
Key Features
Technical Migration Details
Odoo 18 Compatibility
This module has been specifically redesigned for Odoo 18, addressing compatibility breaks from previous versions (v15/v16/v17). Key architectural changes have been implemented to align with Odoo 18's framework requirements while maintaining the module's functionality.
Payment Provider Implementation
The module now implements the
payment.providermodel instead of the deprecatedpayment.acquirermodel that was used in versions prior to v15. This change follows Odoo's payment framework evolution and ensures proper integration with the current payment flow system.Secondary Address System
The module has moved away from using the long
payment_ids(which are no longer supported) to using secondary Monero addresses for payment tracking. This architectural change provides better isolation between transactions and improves the reliability of payment matching.Automated Payment Verification
The module implements Odoo cron jobs to:
This automation ensures payment integrity and reduces manual verification requirements.
Installation Requirements
Configuration
After installation, the module can be configured through the Odoo Payment Provider settings:
Package reorganization
The 2 modules monero-rpc-odoo and monero-rpc-odoo-pos have been merged into one and following the naming convention for payment modules renamed to payment_monero_rpc.
Upgrading from Previous Versions
Due to significant changes in both Odoo's payment framework and this module's architecture, a clean installation is recommended when upgrading from versions prior to Odoo 18. Data migration scripts are included but should be tested in a staging environment before use in production.
Odoo Module Migration Compatibility Table
Overview of Version Transitions
Detailed Migration Compatibility Table
Key Technical Changes By Version
Odoo 15 → 16
ORM Changes:
fields.Date.context_todayin favor of new approachesView Changes:
API Changes:
Odoo 16 → 17
Major Framework Changes:
Core Changes:
Frontend:
Odoo 17 → 18
Technical Foundation:
Developer Experience:
Enterprise Features:
Module Migration Strategy
Common Migration Issues
Best Practices for Migration