llx/builtin_array: nil-check leftArray in cmpArrayOne#7461
Open
SAY-5 wants to merge 2 commits into
Open
Conversation
Closes mondoohq#7258. http.get.header.params[k] returns nil on connection failure; the bare type assertion panicked the shell.
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
![mondoo-code-review[bot]](https://avatars.githubusercontent.com/in/2834902?s=60&v=4){kind=small}
Author
|
CLA pending signature on my end, will sign shortly to unblock. |
arlimus
approved these changes
May 26, 2026
arlimus
left a comment
arlimus
left a comment
Member
There was a problem hiding this comment.
Sorry for being so late on this one! 🙈
Great fix, I'll expand the tests after merging and look for similar issues. I'll keep a closer eye not to let this one slip by again - thank you again!
Member
|
Oh just the CLA is missing! If you would be so kind, it's as simple as adding a commit with the message: e.g. via |
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Author
|
I have read the Mondoo CLA Document and I hereby sign the CLA |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7258.
httpconnection without scheme defaults the resp body to nil;leftArray.Value.([]any)then panics the shell.