Skip to content

MIP-11 revisions for clarity#32

Open
keone wants to merge 2 commits intomainfrom
mip11-gram
Open

MIP-11 revisions for clarity#32
keone wants to merge 2 commits intomainfrom
mip11-gram

Conversation

@keone
Copy link
Copy Markdown
Collaborator

@keone keone commented Apr 15, 2026

No description provided.

@keone keone requested a review from jhb10c April 15, 2026 05:29
Copy link
Copy Markdown
Collaborator

@QEDK QEDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some nits.

Comment thread MIPS/MIP-11.md
2. For each transaction: The priority fee is credited to the distribution account instead of the beneficiary balance.
The distribution account has the following logic:

```
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```python

For Prisma syntax highlighting

Comment thread MIPS/MIP-11.md
The primary consideration is the precision of the reward accumulator.

`External_rewards` requires a minimum amount, defined as the `dust_threshold`, to guarantee a certain decimal accuracy within the accumulator. The minimum threshold for non-zero priority fees must align with the `external_rewards` minimum balance requirement. Any fees under this threshold will not be distributed.
`external_rewards` requires a minimum input amount, defined as the `dust_threshold`, in order to guarantee a certain decimal accuracy within the accumulator. The minimum threshold for non-zero priority fees must align with this `external_rewards` minimum-balance requirement, and any fees below this threshold will not be distributed.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: minimum-balance requirement -> minimum balance requirement

Comment thread MIPS/MIP-11.md
## Copyright
Copyright and related rights waived via CC0. No newline at end of file

Copyright and related rights waived via CC0.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC0 should link to the license file.

@jhb10c
Copy link
Copy Markdown
Contributor

jhb10c commented Apr 15, 2026

All updates lgtm. No updates other than what QEDK referenced. One comment: discussions-to needs to be updated in the metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants