Update UnifiedPush and use OS picker to select non-default distributor#695
Open
p1gp1g wants to merge 4 commits intomollyim:mainfrom
Open
Update UnifiedPush and use OS picker to select non-default distributor#695p1gp1g wants to merge 4 commits intomollyim:mainfrom
p1gp1g wants to merge 4 commits intomollyim:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unifiedpush:connector-ui has been deprecated, it was only used on MainActivity if the distributor was removed
Now, we use the system picker during MainActivity if UnifiedPush is still enabled but the distributor has been removed. And for consistency, I've changed the UnifiedPush config screen to also use this picker
It may be possible to use the new default silently, if the user was using the default one, and it has been removed. This is a pending question for my UX guide :)