Conversation
…apsible_if) Fixes mofa-org#1295 Three nested if / if-let / if guards inside the end-of-stream branch of parse_gemini_sse triggered clippy::collapsible_if. Collapse them into a single flat chain using strip_prefix + .filter() combined with one outer if-let, eliminating the nesting without changing any behaviour. Running cargo clippy -p mofa-foundation -- -D warnings now passes clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1295.
Running `cargo clippy --workspace --all-features -- -D warnings` on
`main` produces three `clippy::collapsible_if` warnings in
`crates/mofa-foundation/src/llm/google.rs` inside the end-of-stream
branch of `parse_gemini_sse`:
Root Cause
The end-of-stream arm of the SSE parser had three levels of nested
`if` / `if let` / `if` guards:
Fix
Collapse the outer three guards into a single flat chain using
`strip_prefix` + `.filter()` so there is only one level of nesting
left (the inner `if let Ok(chunk)`):
Semantics are identical: the filter checks both the non-empty guard and
the
[DONE]sentinel in one step.Verification
cargo clippy -p mofa-foundation -- -D warnings cargo test -p mofa-foundationBoth pass clean.
Checklist
clippy::collapsible_ifwarnings in Gemini SSE parser #1295