fix(cli): correct FATAL log detection and add test coverage for prefix format - #1636
Open
PrinceGautam2106 wants to merge 1 commit into
Open
PrinceGautam2106 wants to merge 1 commit into
PrinceGautam2106 wants to merge 1 commit into
Conversation
Handle FATAL-prefixed log lines without requiring surrounding spaces and add a regression test. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CLI log colorization logic incorrectly checks for " FATAL" (with a leading space):
upper.contains(" FATAL")
This causes logs like:
FATAL: process crashed
to not be detected as fatal errors, since they do not contain a leading space. As a result, such logs are not colorized correctly.
Solution
Updated the condition to correctly detect "FATAL" without requiring a leading space.
This ensures all fatal log messages are consistently identified regardless of formatting.
upper.contains("FATAL")
Improvements