Skip to content

chore: fix 60+ clippy warnings across workspace. #1278

Merged
lijingrs merged 2 commits intomofa-org:mainfrom
Bhanudahiyaa:fix/workspace-clippy-cleanup
Mar 16, 2026
Merged

chore: fix 60+ clippy warnings across workspace. #1278
lijingrs merged 2 commits intomofa-org:mainfrom
Bhanudahiyaa:fix/workspace-clippy-cleanup

Conversation

@Bhanudahiyaa
Copy link
Contributor

@Bhanudahiyaa Bhanudahiyaa commented Mar 15, 2026

Summary

Resolves over 60 cargo clippy warnings across the workspace to ensure compliance with the "MoFA Quality Gate".

Motivation

Maintaining a warning-free codebase is required by MoFA's PR guidelines to prevent build regressions and maintain code quality as the ecosystem grows.

Changes

  1. mofa-kernel: Resolved collapsible_if and ambiguous_glob_reexports.
  2. mofa-foundation: Applied large_enum_variant boxing, type_complexity aliases, and field_reassign_with_default fixes.
  3. mofa-integrations: Fixed get_first and collapsible_if in socketio/speech modules.
  4. mofa-cli/gateway: Standardized doc attributes and collection initialization.

Related Issues

Closes #1277

Testing

  • Verified zero warnings with cargo clippy --workspace --all-features -- -D errors.
  • Completed full cargo test run.

Checklist

  • cargo fmt --check passes
  • cargo clippy --workspace --all-features -- -D errors passes
  • cargo test --workspace --all-features passes
  • cargo build --examples succeeds
  • cargo doc --workspace --no-deps --all-features succeeds
  • Architecture layer rules respected (see CONTRIBUTING.md)
  • Relevant documentation updated

@Bhanudahiyaa Bhanudahiyaa marked this pull request as ready for review March 15, 2026 21:39
@Bhanudahiyaa
Copy link
Contributor Author

Bhanudahiyaa commented Mar 16, 2026

@lijingrs @BH3GEI
Hi maintainers,
It looks like the CI workflows are awaiting approval since this is coming from a fork.
Could someone approve the workflows so the checks can run?
Thanks!

@lijingrs lijingrs merged commit 14457cc into mofa-org:main Mar 16, 2026
@Nixxx19
Copy link
Contributor

Nixxx19 commented Mar 16, 2026

@Bhanudahiyaa nice one!!

@Bhanudahiyaa
Copy link
Contributor Author

@Bhanudahiyaa nice one!!
Thanks mate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: resolve workspace-wide clippy warnings

3 participants