fix(metrics): prevent unbounded growth of business_metrics#1262
Merged
LuigiGonnella merged 1 commit intomofa-org:mainfrom Mar 17, 2026
Merged
Conversation
Replace the unbounded Vec<BusinessMetrics> with a VecDeque capped at 10 000 entries. Oldest entries are evicted O(1) via pop_front() when the limit is reached. Add drain_business_metrics() so exporters can atomically read and clear the buffer each scrape interval. Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
Contributor
Author
|
Hi @mugiwaraluffy56 @LuigiGonnella. |
Collaborator
|
good, concise PR. |
Contributor
Author
|
Thank You! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
business_metricswas stored in aVecwhere every call torecord_business_metric()kept pushing new entries with no limit or cleanup.Over time this could cause unbounded memory growth in long-running services.
This PR replaces the vector with a bounded
VecDequeand addsMAX_BUSINESS_METRICSto cap the buffer size. When the limit is reached, the oldest metric is removed before inserting a new one.Steps to Reproduce
record_business_metric()repeatedly (e.g. per request).Fix
Use a bounded buffer instead of an unbounded vector.
Also adds
drain_business_metrics()so exporters can read and clear buffered metrics safely.Verification
cargo test -p mofa-foundation --lib metrics