fix: fixed hot-reload error propagation and added reload manager regression tests#1245
Open
Ishita-190 wants to merge 1 commit intomofa-org:mainfrom
Open
fix: fixed hot-reload error propagation and added reload manager regression tests#1245Ishita-190 wants to merge 1 commit intomofa-org:mainfrom
Ishita-190 wants to merge 1 commit intomofa-org:mainfrom
Conversation
Contributor
Author
|
@LuigiGonnella please take a look at this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
This PR improves error handling in the plugin hot-reload path and adds regression tests for the reload manager.
Previously, reload operations could appear successful even if an internal step failed. This change ensures reload failures are properly returned to the caller and covered by tests.
🔗 Related Issues
Closes #1236
🧠 Context
The plugin hot-reload manager previously did not propagate errors from internal reload steps. If plugin loading, initialization, or startup failed, the reload path could still return a successful result to the caller.
This made reload failures difficult to detect and left important failure paths untested.
🛠️ Changes
Updated the reload flow in
manager.rsso errors from load/init/start steps are returned instead of being silently ignored.Ensured manual reload calls propagate failures back to the API caller.
Added explicit logging for reload failures triggered by the event loop.
Added regression tests in
hot_reload_manager_tests.rscovering:PluginNotFound)PluginNotFound)LoadErrorandReloadFailed event)🧪 How you Tested
📸 Screenshots / Logs (if applicable)
🧹 Checklist
Code Quality
cargo fmtruncargo clippypasses without warningsTesting
cargo testpasses locally without any errorDocumentation
PR Hygiene
main